[tests] fix --write-outputs pytest option discovery

[haileyok]

Summary

./run-tests.sh --write-outputs was failing with pytest: error: unrecognized arguments: --write-outputs because the option was declared in osprey_worker/src/osprey/engine/conftest.py — pytest never discovers conftests that deep before plugin-loading argparse runs. Move the option registration to osprey_worker/conftest.py and add testpaths = ["osprey_worker"] to root pyproject.toml so pytest discovers it from any invocation directory.

Related Issues/Tasks

Closes #251

Changes Made

• Created osprey_worker/conftest.py with pytest_addoption(--write-outputs) and pytest_configure() (registers project markers).
• Removed those hooks from osprey_worker/src/osprey/engine/conftest.py — fixtures remain in place.
• Added [tool.pytest.ini_options].testpaths = ["osprey_worker"] to root pyproject.toml. This pins rootdir at the worktree root for path-less invocations AND makes pytest's conftest walk find osprey_worker/conftest.py during plugin discovery. The same file is also rootdir for path-scoped invocations inside osprey_worker/, so all four invocation paths work without duplication.

Confidence Level

Confidence Level: Claude

Testing

Verified four pytest invocation modes accept --write-outputs:

• uv run pytest --write-outputs --collect-only -q from worktree root (no path)
• uv run pytest osprey_worker/src/osprey/engine/query_language/tests/test_ast_druid_translator.py --write-outputs --collect-only -q from worktree root
• cd osprey_worker && uv run pytest --write-outputs --collect-only -q
• cd osprey_worker && uv run pytest src/osprey/engine/query_language/tests/test_ast_druid_translator.py --write-outputs --collect-only -q

Also:

• uv run ruff format --check . — passes.
• uv run ruff check osprey_worker/conftest.py osprey_worker/src/osprey/engine/conftest.py — clean.
• Default uv run pytest --collect-only -q still collects 1127 tests.

Cycle notes

This branch went through three review cycles. The first attempt put conftest.py at the worktree root but the file wasn't shipped into the test_runner container and rootdir shifted for osprey_worker/-scoped invocations. The second attempt duplicated conftest files with try/except guards. This final shape adopts the reviewer's recommended single-source-of-truth via testpaths.

Summary by CodeRabbit

• Chores
  • Reorganized pytest configuration infrastructure by consolidating root-level test setup and configuration.
  • Added custom pytest markers for validators, UDF registry, and version-specific output testing.
  • Implemented --write-outputs command-line option for test execution.
  • Updated project configuration to standardize test discovery paths.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d65b0a9-7480-47e3-a366-97793c321a64

📥 Commits

Reviewing files that changed from the base of the PR and between 615ac01 and f9dc062.

📒 Files selected for processing (3)

• osprey_worker/conftest.py
• osprey_worker/src/osprey/engine/conftest.py
• pyproject.toml

💤 Files with no reviewable changes (1)

• osprey_worker/src/osprey/engine/conftest.py

---

📝 Walkthrough

Walkthrough

This PR relocates pytest configuration from a nested conftest.py to the root osprey_worker/conftest.py, registers the --write-outputs command-line option and custom pytest markers at the root level, constrains test discovery to the osprey_worker directory in pyproject.toml, and removes the duplicate hook implementations from the nested location.

Changes

Pytest Configuration Relocation

Layer / File(s)	Summary
Root conftest with pytest hooks osprey_worker/conftest.py	New root-level conftest implements pytest_addoption to register --write-outputs option and pytest_configure to register custom markers (use_validators, use_standard_rules_validators, inject_validator_result, use_udf_registry, use_osprey_stdlib, vary_output_by_py_version) via type-guarded imports.
Test discovery configuration pyproject.toml	Adds [tool.pytest.ini_options] section with testpaths = ["osprey_worker"] to constrain pytest test discovery to the osprey_worker directory.
Nested conftest cleanup osprey_worker/src/osprey/engine/conftest.py	Removes _pytest.config.Config and _pytest.config.argparsing.Parser from TYPE_CHECKING imports and deletes the duplicate pytest_addoption and pytest_configure hook functions.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title '[tests] fix --write-outputs pytest option discovery' directly describes the main change: moving pytest option registration to ensure discovery before argparse runs.
Linked Issues check	✅ Passed	The PR fulfills all requirements from #251: registers --write-outputs in root conftest for early discovery, adds testpaths to ensure discovery, verified across all invocation modes, and preserves test behavior.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the --write-outputs discovery issue: root conftest registration, engine conftest cleanup, and testpaths configuration with no extraneous modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/bug-251-write-outputs

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chimosky]

The license excerpt is usually inserted in every file created, but I noticed that's not the case here, is this for consistency as no file in the repo has the excerpt?

[chimosky]

Tested all four invocation modes, works as expected.