[osprey-ui] Rules Registry page

[haileyok]

Description

Migrating another internal page to upstream. This one complements the features registry by displaying all of the rules that exist within Osprey.

Changes Made

Backend (osprey_worker):

• Renamed _features_ast_utils.py → _engine_ast_utils.py and promoted _collect_name_references to a public collect_name_references helper now shared by features.py and rules.py.
• New views/rules.py Flask blueprint: _build_whenrules_ref_count (sub-pass 1, counts WhenRules → Rule refs), _extract_rules_from_engine (sub-pass 2, collects Rule nodes), and rules_list route gated by @require_ability(CanViewDocs).
• Registered the blueprint in app.py so both /rules and /api/rules resolve.
• New tests/test_rules.py with 7 tests covering empty engine, response shape, FormatString descriptions, back-reference regression, unused_total correctness, dual-route equality, and 401 gating.

Frontend (osprey_ui):

• New types/RulesTypes.tsx (RuleInfo, RulesListResponse, SortKey), actions/RulesActions.tsx (getRulesList), and Routes.RULES = '/rules'.
• New components/rules/RulesPage.tsx — five components in post-nit FeaturesPage form: thin shell uses usePromiseResult + renderFromPromiseResult; RulesPageContent owns a single useReducer<FiltersState, FiltersAction> for filters and pagination, with every filter action atomically resetting page: 1 (no cross-effect useEffect needed); RuleDetail uses the Antd 5 Descriptions styles={{ label: ... }} API.
• Route + NavBar Manage-section entry (FileTextOutlined, label "Rules") wired in.

Confidence Level

Confidence Level: Claude

Testing

Static / type checks (passed in-session):

• python3 -c "import ast; ast.parse(...)" on all touched .py files.
• ruff check --select E,F,I clean on features.py, _engine_ast_utils.py, rules.py, test_rules.py, app.py.
• cd osprey_ui && npx tsc --noEmit clean.
• AC4 grep checks pass: no useEffect (except an explanatory comment), no useState, no unbraced arrow callbacks, no deprecated labelStyle.

Checklist

• Tests pass locally — pending pytest run
• uv run ruff check . passes — --select E,F,I clean on all touched files
• uv tool run fawltydeps --check-unused --pyenv .venv passes — pending
• Updated CHANGELOG.md with my changes, if applicable — not applicable (no CHANGELOG convention spotted in repo)

---

🤖 Generated with Claude Code

[haileyok]

Preview:

[Copilot]

Pull request overview

Adds a new “Rules Registry” view to the upstream UI/API, analogous to the existing Features Registry, exposing a catalog of Rule(...) definitions and their usage from WhenRules(...) blocks.

Changes:

• Backend: adds a /rules (and /api/rules) endpoint gated by CanViewDocs, plus shared AST utilities for name-reference collection.
• Backend tests: introduces a dedicated test_rules.py suite covering response shape, FormatString descriptions, reference counting, dual-route registration, and auth gating.
• Frontend: adds a new /rules route and page with filtering/sorting/pagination, types/actions wiring, and a NavBar entry.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
osprey_worker/src/osprey/worker/ui_api/osprey/views/tests/test_rules.py	Adds coverage for the new rules registry endpoint (shape, refs, auth, route aliases).
osprey_worker/src/osprey/worker/ui_api/osprey/views/rules.py	Implements the Rules API blueprint and extraction logic from the engine AST.
osprey_worker/src/osprey/worker/ui_api/osprey/views/features.py	Switches to shared AST helper (collect_name_references) after util consolidation.
osprey_worker/src/osprey/worker/ui_api/osprey/views/_engine_ast_utils.py	Generalizes AST helper module and exposes collect_name_references.
osprey_worker/src/osprey/worker/ui_api/osprey/app.py	Registers the new rules blueprint (root + /api prefix).
osprey_ui/src/types/RulesTypes.tsx	Adds frontend types for rules list payload and sorting.
osprey_ui/src/Constants.tsx	Adds Routes.RULES.
osprey_ui/src/components/rules/RulesPage.tsx	Implements the Rules Registry UI (filters, sorting, pagination, details view).
osprey_ui/src/components/rules/RulesPage.module.css	Styles for the new Rules page.
osprey_ui/src/components/navigation/NavBar.tsx	Adds “Rules” entry to the Manage section.
osprey_ui/src/App.tsx	Registers the /rules route to render RulesPage.
osprey_ui/src/actions/RulesActions.tsx	Adds getRulesList API call wrapper.
CHANGELOG.md	Notes the new Rules Registry page addition.

[julietshen]

Feedback from an adopter: Can we add a visual chart on the bottom of each rule to see when / how often it triggers?

[haileyok]

Feedback from an adopter: Can we add a visual chart on the bottom of each rule to see when / how often it triggers?

this should be relatively easy to do i think...the data is already in druid so