Skip to content

Stable project identity from git remote + default remember to project scope #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devon3000 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Stable project identity from git remote + default remember to project scope #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
059e41e
feat(project): opt-in stable project identity from git remote
devon3000 May 30, 2026
739b629
feat(scripts): one-time project-identity backfill
devon3000 May 30, 2026
a2da423
feat(remember): default memory_save to current project scope
devon3000 May 30, 2026
a83618a
fix(plugin): rebuild session-end.mjs so remote identity applies there…
devon3000 Aug 17, 2026
90640b9
fix(project): lowercase the owner/repo path, not just the host
devon3000 Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 55 additions & 7 deletions plugin/scripts/notification.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
import { execSync } from "node:child_process";
import { basename } from "node:path";
//#region src/hooks/_project.ts
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();
function gitToplevelBasename(dir) {
try {
const top = execSync("git rev-parse --show-toplevel", {
cwd: dir,
Expand All @@ -16,9 +13,60 @@ function resolveProject(cwd) {
],
timeout: 500
}).toString().trim();
if (top) return basename(top);
} catch {}
return basename(dir);
return top ? basename(top) : null;
} catch {
return null;
}
}
function normalizeGitRemote(url) {
const raw = (url ?? "").trim();
if (!raw) return null;
let host = "";
let path = "";
const scp = raw.match(/^[^@/]+@([^:/]+):(.+)$/);
if (scp) {
host = scp[1];
path = scp[2];
} else {
const noCreds = raw.replace(/^[a-zA-Z][a-zA-Z0-9+.-]*:\/\//, "").replace(/^[^@/]*@/, "");
const slash = noCreds.indexOf("/");
if (slash === -1) return null;
host = noCreds.slice(0, slash);
path = noCreds.slice(slash + 1);
}
host = host.toLowerCase().replace(/:\d+$/, "");
path = path.replace(/^\/+/, "").replace(/\/+$/, "").replace(/\.git$/i, "").toLowerCase();
if (!host || !path) return null;
return `${host}/${path}`;
}
function gitRemoteIdentity(dir) {
try {
return normalizeGitRemote(execSync("git config --get remote.origin.url", {
cwd: dir,
stdio: [
"ignore",
"pipe",
"ignore"
],
timeout: 500
}).toString().trim());
} catch {
return null;
}
}
function remoteIdentityEnabled() {
const flag = process.env["AGENTMEMORY_PROJECT_FROM_REMOTE"];
return flag === "1" || flag === "true";
}
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();
if (remoteIdentityEnabled()) {
const id = gitRemoteIdentity(dir);
if (id) return id;
}
return gitToplevelBasename(dir) ?? basename(dir);
}
function hookCwd(data) {
if (!data || typeof data !== "object") return void 0;
Expand Down
62 changes: 55 additions & 7 deletions plugin/scripts/post-tool-failure.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
import { execSync } from "node:child_process";
import { basename } from "node:path";
//#region src/hooks/_project.ts
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();
function gitToplevelBasename(dir) {
try {
const top = execSync("git rev-parse --show-toplevel", {
cwd: dir,
Expand All @@ -16,9 +13,60 @@ function resolveProject(cwd) {
],
timeout: 500
}).toString().trim();
if (top) return basename(top);
} catch {}
return basename(dir);
return top ? basename(top) : null;
} catch {
return null;
}
}
function normalizeGitRemote(url) {
const raw = (url ?? "").trim();
if (!raw) return null;
let host = "";
let path = "";
const scp = raw.match(/^[^@/]+@([^:/]+):(.+)$/);
if (scp) {
host = scp[1];
path = scp[2];
} else {
const noCreds = raw.replace(/^[a-zA-Z][a-zA-Z0-9+.-]*:\/\//, "").replace(/^[^@/]*@/, "");
const slash = noCreds.indexOf("/");
if (slash === -1) return null;
host = noCreds.slice(0, slash);
path = noCreds.slice(slash + 1);
}
host = host.toLowerCase().replace(/:\d+$/, "");
path = path.replace(/^\/+/, "").replace(/\/+$/, "").replace(/\.git$/i, "").toLowerCase();
if (!host || !path) return null;
return `${host}/${path}`;
}
function gitRemoteIdentity(dir) {
try {
return normalizeGitRemote(execSync("git config --get remote.origin.url", {
cwd: dir,
stdio: [
"ignore",
"pipe",
"ignore"
],
timeout: 500
}).toString().trim());
} catch {
return null;
}
}
function remoteIdentityEnabled() {
const flag = process.env["AGENTMEMORY_PROJECT_FROM_REMOTE"];
return flag === "1" || flag === "true";
}
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();
if (remoteIdentityEnabled()) {
const id = gitRemoteIdentity(dir);
if (id) return id;
}
return gitToplevelBasename(dir) ?? basename(dir);
}
function hookCwd(data) {
if (!data || typeof data !== "object") return void 0;
Expand Down
62 changes: 55 additions & 7 deletions plugin/scripts/post-tool-use.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
import { execSync } from "node:child_process";
import { basename } from "node:path";
//#region src/hooks/_project.ts
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();
function gitToplevelBasename(dir) {
try {
const top = execSync("git rev-parse --show-toplevel", {
cwd: dir,
Expand All @@ -16,9 +13,60 @@ function resolveProject(cwd) {
],
timeout: 500
}).toString().trim();
if (top) return basename(top);
} catch {}
return basename(dir);
return top ? basename(top) : null;
} catch {
return null;
}
}
function normalizeGitRemote(url) {
const raw = (url ?? "").trim();
if (!raw) return null;
let host = "";
let path = "";
const scp = raw.match(/^[^@/]+@([^:/]+):(.+)$/);
if (scp) {
host = scp[1];
path = scp[2];
} else {
const noCreds = raw.replace(/^[a-zA-Z][a-zA-Z0-9+.-]*:\/\//, "").replace(/^[^@/]*@/, "");
const slash = noCreds.indexOf("/");
if (slash === -1) return null;
host = noCreds.slice(0, slash);
path = noCreds.slice(slash + 1);
}
host = host.toLowerCase().replace(/:\d+$/, "");
path = path.replace(/^\/+/, "").replace(/\/+$/, "").replace(/\.git$/i, "").toLowerCase();
if (!host || !path) return null;
return `${host}/${path}`;
Comment on lines +21 to +40

@coderabbitai coderabbitai Bot May 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Return null for local-path remotes instead of treating them as canonical IDs.

With AGENTMEMORY_PROJECT_FROM_REMOTE=1, a local origin like C:/work/repo.git currently normalizes to c:/work/repo, which is machine-specific and reintroduces the fragmentation this feature is meant to eliminate. These cases should fail normalization so resolveProject() falls back to the git toplevel/cwd basename.

Suggested fix 
 function normalizeGitRemote(url) {
 	const raw = (url ?? "").trim();
 	if (!raw) return null;
+	if (/^(file:|\/|\.{1,2}[\\/]|[A-Za-z]:[\\/]|\\\\)/.test(raw)) return null;
 	let host = "";
 	let path = "";
 	const scp = raw.match(/^[^`@/`]+@([^:/]+):(.+)$/);
 	if (scp) {
 		host = scp[1];
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
function normalizeGitRemote(url) {
const raw = (url ?? "").trim();
if (!raw) return null;
let host = "";
let path = "";
const scp = raw.match(/^[^@/]+@([^:/]+):(.+)$/);
if (scp) {
host = scp[1];
path = scp[2];
} else {
const noCreds = raw.replace(/^[a-zA-Z][a-zA-Z0-9+.-]*:\/\//, "").replace(/^[^@/]*@/, "");
const slash = noCreds.indexOf("/");
if (slash === -1) return null;
host = noCreds.slice(0, slash);
path = noCreds.slice(slash + 1);
}
host = host.toLowerCase().replace(/:\d+$/, "");
path = path.replace(/^\/+/, "").replace(/\/+$/, "").replace(/\.git$/i, "");
if (!host || !path) return null;
return `${host}/${path}`;
function normalizeGitRemote(url) {
const raw = (url ?? "").trim();
if (!raw) return null;
if (/^(file:|\/|\.{1,2}[\\/]|[A-Za-z]:[\\/]|\\\\)/.test(raw)) return null;
let host = "";
let path = "";
const scp = raw.match(/^[^`@/`]+@([^:/]+):(.+)$/);
if (scp) {
host = scp[1];
path = scp[2];
} else {
const noCreds = raw.replace(/^[a-zA-Z][a-zA-Z0-9+.-]*:\/\//, "").replace(/^[^`@/`]*`@/`, "");
const slash = noCreds.indexOf("/");
if (slash === -1) return null;
host = noCreds.slice(0, slash);
path = noCreds.slice(slash + 1);
}
host = host.toLowerCase().replace(/:\d+$/, "");
path = path.replace(/^\/+/, "").replace(/\/+$/, "").replace(/\.git$/i, "");
if (!host || !path) return null;
return `${host}/${path}`;
}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugin/scripts/post-tool-use.mjs` around lines 22 - 41, normalizeGitRemote
currently treats local filesystem paths like "C:/work/repo.git" as valid
remotes; update normalizeGitRemote to detect and reject local-path remotes by
returning null so resolveProject() can fall back to repo top-level. Before
parsing/scp handling, add a guard that returns null when raw matches local path
patterns (e.g., starts with "/", "./", "../", "~/" or Windows drive-letter
patterns like /^[A-Za-z]:[\\/]/, or contains backslashes without a
protocol/user@host), then continue the existing scp/noCreds logic; reference the
normalizeGitRemote function and its local variables raw, scp, noCreds, host, and
path when making the change.

}
function gitRemoteIdentity(dir) {
try {
return normalizeGitRemote(execSync("git config --get remote.origin.url", {
cwd: dir,
stdio: [
"ignore",
"pipe",
"ignore"
],
timeout: 500
}).toString().trim());
} catch {
return null;
}
}
function remoteIdentityEnabled() {
const flag = process.env["AGENTMEMORY_PROJECT_FROM_REMOTE"];
return flag === "1" || flag === "true";
}
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();

@coderabbitai coderabbitai Bot Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Guard cwd.trim() with a string check to prevent runtime crash.

Line 65 can throw when cwd is present but non-string (e.g., malformed hook payload), which aborts observation submission.

Suggested patch 
-	const dir = cwd && cwd.trim() ? cwd : process.cwd();
+	const dir = typeof cwd === "string" && cwd.trim() ? cwd : process.cwd();
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const dir = cwd && cwd.trim() ? cwd : process.cwd();
const dir = typeof cwd === "string" && cwd.trim() ? cwd : process.cwd();
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugin/scripts/post-tool-use.mjs` at line 65, The current assignment for dir
uses cwd && cwd.trim() which will throw if cwd is non-string; update the guard
to check the type first (e.g., use typeof cwd === "string" && cwd.trim() ? cwd :
process.cwd()) so that the variable dir is safely set without calling trim on
non-strings; change the expression where dir is assigned (the cwd and trim
check) to this type-safe form referencing the cwd variable and dir assignment.

if (remoteIdentityEnabled()) {
const id = gitRemoteIdentity(dir);
if (id) return id;
}
return gitToplevelBasename(dir) ?? basename(dir);
}
function hookCwd(data) {
if (!data || typeof data !== "object") return void 0;
Expand Down
62 changes: 55 additions & 7 deletions plugin/scripts/pre-compact.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
import { execSync } from "node:child_process";
import { basename } from "node:path";
//#region src/hooks/_project.ts
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();
function gitToplevelBasename(dir) {
try {
const top = execSync("git rev-parse --show-toplevel", {
cwd: dir,
Expand All @@ -16,9 +13,60 @@ function resolveProject(cwd) {
],
timeout: 500
}).toString().trim();
if (top) return basename(top);
} catch {}
return basename(dir);
return top ? basename(top) : null;
} catch {
return null;
}
}
function normalizeGitRemote(url) {
const raw = (url ?? "").trim();
if (!raw) return null;
let host = "";
let path = "";
const scp = raw.match(/^[^@/]+@([^:/]+):(.+)$/);
if (scp) {
host = scp[1];
path = scp[2];
} else {
const noCreds = raw.replace(/^[a-zA-Z][a-zA-Z0-9+.-]*:\/\//, "").replace(/^[^@/]*@/, "");
const slash = noCreds.indexOf("/");
if (slash === -1) return null;
host = noCreds.slice(0, slash);
path = noCreds.slice(slash + 1);
}
host = host.toLowerCase().replace(/:\d+$/, "");
path = path.replace(/^\/+/, "").replace(/\/+$/, "").replace(/\.git$/i, "").toLowerCase();
if (!host || !path) return null;
return `${host}/${path}`;
}
function gitRemoteIdentity(dir) {
try {
return normalizeGitRemote(execSync("git config --get remote.origin.url", {
cwd: dir,
stdio: [
"ignore",
"pipe",
"ignore"
],
timeout: 500
}).toString().trim());
} catch {
return null;
}
}
function remoteIdentityEnabled() {
const flag = process.env["AGENTMEMORY_PROJECT_FROM_REMOTE"];
return flag === "1" || flag === "true";
}
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();
if (remoteIdentityEnabled()) {
const id = gitRemoteIdentity(dir);
if (id) return id;
}
return gitToplevelBasename(dir) ?? basename(dir);
}
function hookCwd(data) {
if (!data || typeof data !== "object") return void 0;
Expand Down
62 changes: 55 additions & 7 deletions plugin/scripts/prompt-submit.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
import { execSync } from "node:child_process";
import { basename } from "node:path";
//#region src/hooks/_project.ts
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();
function gitToplevelBasename(dir) {
try {
const top = execSync("git rev-parse --show-toplevel", {
cwd: dir,
Expand All @@ -16,9 +13,60 @@ function resolveProject(cwd) {
],
timeout: 500
}).toString().trim();
if (top) return basename(top);
} catch {}
return basename(dir);
return top ? basename(top) : null;
} catch {
return null;
}
}
function normalizeGitRemote(url) {
const raw = (url ?? "").trim();
if (!raw) return null;
let host = "";
let path = "";
const scp = raw.match(/^[^@/]+@([^:/]+):(.+)$/);
if (scp) {
host = scp[1];
path = scp[2];
} else {
const noCreds = raw.replace(/^[a-zA-Z][a-zA-Z0-9+.-]*:\/\//, "").replace(/^[^@/]*@/, "");
const slash = noCreds.indexOf("/");
if (slash === -1) return null;
host = noCreds.slice(0, slash);
path = noCreds.slice(slash + 1);
}
host = host.toLowerCase().replace(/:\d+$/, "");
path = path.replace(/^\/+/, "").replace(/\/+$/, "").replace(/\.git$/i, "").toLowerCase();
if (!host || !path) return null;
return `${host}/${path}`;
}
function gitRemoteIdentity(dir) {
try {
return normalizeGitRemote(execSync("git config --get remote.origin.url", {
cwd: dir,
stdio: [
"ignore",
"pipe",
"ignore"
],
timeout: 500
}).toString().trim());
} catch {
return null;
}
}
function remoteIdentityEnabled() {
const flag = process.env["AGENTMEMORY_PROJECT_FROM_REMOTE"];
return flag === "1" || flag === "true";
}
function resolveProject(cwd) {
const explicit = process.env["AGENTMEMORY_PROJECT_NAME"];
if (explicit && explicit.trim()) return explicit.trim();
const dir = cwd && cwd.trim() ? cwd : process.cwd();
if (remoteIdentityEnabled()) {
const id = gitRemoteIdentity(dir);
if (id) return id;
}
return gitToplevelBasename(dir) ?? basename(dir);
}
function hookCwd(data) {
if (!data || typeof data !== "object") return void 0;
Expand Down
Loading