Skip to content

Fix weak type operators and JSON baseline output - #25

Merged
rogerchappel merged 4 commits into
mainfrom
agent/oss-7d25c96ce7ad-type-operator-json-baseline
Aug 28, 2026
Merged

rogerchappel merged 4 commits into
mainfrom
agent/oss-7d25c96ce7ad-type-operator-json-baseline

Conversation

@rogerchappel

Copy link
Copy Markdown
Owner

Summary

  • unwrap TSTypeOperator annotations so keyof any, keyof unknown, and readonly weak arrays retain their weak classification
  • keep --format json --baseline stdout to one parseable JSON report while sending the save confirmation to stderr
  • add focused parser and CLI regressions that verify wrapper classification, the saved baseline, and machine output

Verification

  • Tests or checks run: npm run release:check (123 tests, typecheck, lint, audits, build, validation, smoke, package smoke)
  • Manual review completed: full diff and git diff --check origin/main...HEAD

Commit-by-commit changes

  • a4687cf test: expose weak type operator wrappers
  • 49662a4 fix: unwrap type operator annotations
  • ed414c1 test: cover JSON baseline output
  • 469322e fix: preserve JSON baseline output

Risk Level

  • Low
  • Medium
  • High

Notes: The text-mode confirmation remains on stdout; only JSON mode routes it to stderr to preserve the machine-readable contract.

Rollback Plan

  • Revert the four commits in reverse order.

Human Decision Needed

  • None
  • Maintainer review
  • Product/design decision
  • Security/privacy review
  • Other:

@rogerchappel

Copy link
Copy Markdown
Owner Author

Automated merge note

Triage class: auto-merge

Summary: Unwraps weak type operators so nested any/unknown remains detectable, and keeps --format json --baseline stdout parseable while preserving the baseline and confirmation.

Checks run: GitHub CI test completed SUCCESS on Node 20.19.0, 22, and 24; worker verification passed npm ci, targeted parser/CLI regressions, npm run release:check (123/123 tests, audits, typecheck, lint, build, validation, smoke, package smoke), and git diff --check origin/main...HEAD. Final diff (4 files, +43/-3), mergeability, one-review branch protection, and checks were re-read immediately before merge.

Rebased/CI-repaired: No.

Verified head SHA: 469322e515a9fcaa68e6d151609a6eff5bbb139e.

@rogerchappel
rogerchappel merged commit 22ede3a into main Aug 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant