Skip to content

ENG-3508 Fix release-tag workflow cache cleanup - #81

Merged
sahil-roe merged 1 commit into
mainfrom
sahil/eng-3508-disable-release-tag-cache
Sep 19, 2026
Merged

sahil-roe merged 1 commit into
mainfrom
sahil/eng-3508-disable-release-tag-cache

Conversation

@sahil-roe

Copy link
Copy Markdown
Contributor

Disable uv cache uploads in the release-tag workflow. A merge without a pyproject.toml change skips dependency installation, leaving no cache directory; setup-uv's post-job cache save then fails even though tagging was correctly skipped.

The version detection and tag creation logic are unchanged. Tracks ENG-3508.

Self-review

Reviewed the complete one-line diff against main; no actionable findings. No Python source or dependencies changed.

Test Plan

  • Parsed workflow YAML and checked the supported setup-uv enable-cache input.
  • Executed the version-detection script against the original no-version-change merge; it exits successfully with no version output, leaving tag creation skipped.
  • git diff --check passes.
  • Verify the release-tag workflow succeeds on the main push after merge; this workflow only runs on main pushes.

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the change disables only an optional cache optimization while preserving uv installation and release-tag behavior.

Summary

Disables uv caching in the release-tag workflow so pushes without dependency installation do not fail during the post-job cache upload.

  • Leaves version detection and tag creation unchanged.
  • Uses a supported setup-uv input value.
  • No Python source code or dependencies are changed.

Reviews (1) · Last reviewed commit: "- Disable unused release-tag uv cache (E..."

@sahil-roe
sahil-roe merged commit 811fd0a into main Sep 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants