Skip to content

ENG-2664 Remove legacy lens and draft APIs from the Python SDK - #80

Merged
sahil-roe merged 1 commit into
mainfrom
sahil/eng-2664-remove-legacy-lens-sdk
Sep 18, 2026
Merged

sahil-roe merged 1 commit into
mainfrom
sahil/eng-2664-remove-legacy-lens-sdk

Conversation

@sahil-roe

@sahil-roe sahil-roe commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Retire the lens/draft SDK API as part of ENG-2664.

Remove the handwritten knowledge-base facade and its RoeClient import, initialization, and property. Regenerate the raw endpoints, models, wrapper contract, and examples from the roe-main SDK source so removing the backend lens endpoints leaves RoeClient importable.

Companion backend cleanup: roe-main #4248. Land the matching SDK cleanup before the next SDK regeneration/release from that backend change.

Self-review

Full branch diff reviewed against the merge base with main. No actionable findings or P0/P1 blockers. This intentionally removes the legacy lens/draft SDK API.

Test Plan

  • uv run --locked pytest -q: 62 passed.
  • Full Ruff lint and format checks passed.
  • Regenerated twice with scripts/generate-sdk; no codegen drift.

- Regenerate contracts, clients, and examples from roe-main
@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the retired API surface is removed consistently and no actionable regressions remain.

Summary

This PR consistently removes the retired knowledge-base lens and draft API surface from the Python SDK.

  • Removes the handwritten KnowledgeBaseAPI facade and its RoeClient integration.
  • Removes corresponding OpenAPI paths, wrapper declarations, generated endpoints, and generated models.
  • Removes obsolete examples and transport tests.
  • Regenerates job-result models to match the current OpenAPI optionality of cost and token fields.

Reviews (1) · Last reviewed commit: "- Remove legacy lens and draft SDK APIs ..."

@sahil-roe
sahil-roe merged commit 79d077e into main Sep 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants