Skip to content

Add skill_generation_state to BaseAgent test fixture - #77

Closed
Chen-ROE wants to merge 1 commit into
mainfrom
chen/fixture-skill-generation-state
Closed

Chen-ROE wants to merge 1 commit into
mainfrom
chen/fixture-skill-generation-state

Conversation

@Chen-ROE

@Chen-ROE Chen-ROE commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Release v1.1.12 (#76, generated from roe-main 1-0-96) adds a required, nullable skill_generation_state field to BaseAgent. The hand-written _base_agent_json() fixture in tests/unit/test_agents_wrapper_transport.py predates it, so the regenerated BaseAgent.from_dict raises KeyError: 'skill_generation_state' and the test job on #76 fails.

This adds the key (as None) to the fixture. Landing it on main first is required: the release bot rebuilds the release-sdk-python-* branch from main on every re-run, so a commit pushed directly onto #76 would be overwritten.

Test Plan

  • Regenerated the SDK locally from the 1-0-96 spec (bash scripts/generate-sdk), ran uv run pytest: 1 failed / 66 passed without this change, 67 passed with it.
  • CI green on this PR.
  • After merge, re-run the roe-main 1-0-96 release workflow and confirm Release v1.1.12 #76 goes green.

🤖 Generated with Claude Code

Release 1.1.12 (roe-main 1-0-96) adds a required, nullable
skill_generation_state field to BaseAgent. The hand-written fixture in
test_agents_wrapper_transport.py predates it, so the generated
BaseAgent.from_dict raises KeyError and the release PR's test job fails.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown

Greptile Summary

Updates the hand-written BaseAgent response fixture to include the newly required nullable skill_generation_state field.

  • Keeps the fixture aligned with the regenerated SDK model expected in the upcoming release.
  • Uses None to represent the nullable API value.

Confidence Score: 5/5

The PR appears safe to merge and introduces no actionable correctness, security, or maintainability issues.

The fixture-only change uses the intended nullable value and remains compatible with both the current model’s additional-property handling and the regenerated model described by the PR.

Important Files Changed

Filename Overview
tests/unit/test_agents_wrapper_transport.py Adds the nullable skill_generation_state key to the BaseAgent transport-test fixture.

Reviews (1): Last reviewed commit: "Add skill_generation_state to BaseAgent ..." | Re-trigger Greptile

@Chen-ROE

Chen-ROE commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Superseded: the one-line fixture change was pushed directly onto #76 (release-sdk-python-1-0-96). Note #76 must merge before the roe-main release workflow is re-run, since the release bot rebuilds that branch from main on each run.

@Chen-ROE Chen-ROE closed this Sep 5, 2026
@Chen-ROE
Chen-ROE deleted the chen/fixture-skill-generation-state branch September 5, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant