Conversation
Release 1.1.12 (roe-main 1-0-96) adds a required, nullable skill_generation_state field to BaseAgent. The hand-written fixture in test_agents_wrapper_transport.py predates it, so the generated BaseAgent.from_dict raises KeyError and the release PR's test job fails. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Greptile SummaryUpdates the hand-written
Confidence Score: 5/5The PR appears safe to merge and introduces no actionable correctness, security, or maintainability issues. The fixture-only change uses the intended nullable value and remains compatible with both the current model’s additional-property handling and the regenerated model described by the PR. Important Files Changed
Reviews (1): Last reviewed commit: "Add skill_generation_state to BaseAgent ..." | Re-trigger Greptile |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release v1.1.12 (#76, generated from roe-main
1-0-96) adds a required, nullableskill_generation_statefield toBaseAgent. The hand-written_base_agent_json()fixture intests/unit/test_agents_wrapper_transport.pypredates it, so the regeneratedBaseAgent.from_dictraisesKeyError: 'skill_generation_state'and thetestjob on #76 fails.This adds the key (as
None) to the fixture. Landing it onmainfirst is required: the release bot rebuilds therelease-sdk-python-*branch frommainon every re-run, so a commit pushed directly onto #76 would be overwritten.Test Plan
bash scripts/generate-sdk), ranuv run pytest: 1 failed / 66 passed without this change, 67 passed with it.🤖 Generated with Claude Code