-
-
Notifications
You must be signed in to change notification settings - Fork 87
Complete the FluentMap 3.x generated/AOT and API governance roadmap #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d85b5d1
fix: stabilize compatibility contract (#212)
rodri-oliveira-dev 361ffdf
feat: expand strict generated materialization (#213)
rodri-oliveira-dev 81b7888
feat: complete advanced mapping capabilities (#214)
rodri-oliveira-dev 23684c6
feat: [Roadmap] FluentMap 3.x: generated/AOT maturity, mapping comple…
rodri-oliveira-dev 0a0f5e9
chore: complete API governance and regression evidence (#215)
rodri-oliveira-dev 30839b1
docs: reconcile roadmap governance evidence
rodri-oliveira-dev af515c7
fix: harden roadmap CI and strict AOT paths
rodri-oliveira-dev e9930ef
fix: resolve automated roadmap review findings
rodri-oliveira-dev 7e552ee
docs: clarify generated construction detection
rodri-oliveira-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| name: Compatibility Canary | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "43 7 * * 2" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: compatibility-canary-${{ github.repository }} | ||
| cancel-in-progress: false | ||
|
|
||
| env: | ||
| DOTNET_CLI_TELEMETRY_OPTOUT: "true" | ||
| DOTNET_SKIP_FIRST_TIME_EXPERIENCE: "true" | ||
|
|
||
| jobs: | ||
| supported-dapper: | ||
| name: Supported evidence (${{ matrix.label }}, Dapper ${{ matrix.version }}) | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 25 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - label: minimum-supported | ||
| version: 2.1.79 | ||
| - label: latest-supported | ||
| version: 2.1.89 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6 | ||
| with: | ||
| global-json-file: global.json | ||
|
|
||
| - name: Restore supported lane | ||
| run: dotnet restore ./Dapper.FluentMap.slnx -p:DapperPackageVersion=${{ matrix.version }} | ||
|
|
||
| - name: Build supported lane | ||
| run: dotnet build ./Dapper.FluentMap.slnx --configuration Release --no-restore -p:DapperPackageVersion=${{ matrix.version }} | ||
|
|
||
| - name: Test supported lane | ||
| run: >- | ||
| dotnet test ./test/Dapper.FluentMap.Tests/Dapper.FluentMap.Tests.csproj | ||
| --configuration Release --no-build | ||
|
|
||
| forward-dapper: | ||
| name: Experimental forward Dapper | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 25 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6 | ||
| with: | ||
| global-json-file: global.json | ||
|
|
||
| - name: Resolve forward-looking Dapper version | ||
| id: resolve | ||
| shell: pwsh | ||
| run: | | ||
| $ErrorActionPreference = 'Stop' | ||
| $supported = '2.1.89' | ||
| $index = Invoke-RestMethod 'https://api.nuget.org/v3-flatcontainer/dapper/index.json' | ||
| $candidates = @( | ||
| $index.versions | | ||
| Where-Object { [version](($_ -split '-', 2)[0]) -gt [version]$supported } | | ||
| Sort-Object { [version](($_ -split '-', 2)[0]) } | ||
| ) | ||
| $candidate = if ($candidates.Count -eq 0) { $null } else { $candidates[-1] } | ||
| $available = -not [string]::IsNullOrWhiteSpace($candidate) | ||
| "available=$($available.ToString().ToLowerInvariant())" >> $env:GITHUB_OUTPUT | ||
| "version=$candidate" >> $env:GITHUB_OUTPUT | ||
| if ($available) { | ||
| "### Experimental Dapper candidate: $candidate" >> $env:GITHUB_STEP_SUMMARY | ||
| } else { | ||
| '### No newer Dapper stable/prerelease is currently resolvable.' >> $env:GITHUB_STEP_SUMMARY | ||
| } | ||
|
|
||
| - name: Restore experimental lane | ||
| if: ${{ steps.resolve.outputs.available == 'true' }} | ||
| run: dotnet restore ./Dapper.FluentMap.slnx -p:DapperPackageVersion=${{ steps.resolve.outputs.version }} | ||
|
|
||
| - name: Build experimental lane | ||
| if: ${{ steps.resolve.outputs.available == 'true' }} | ||
| run: dotnet build ./Dapper.FluentMap.slnx --configuration Release --no-restore -p:DapperPackageVersion=${{ steps.resolve.outputs.version }} | ||
|
|
||
| - name: Test experimental lane | ||
| if: ${{ steps.resolve.outputs.available == 'true' }} | ||
| run: >- | ||
| dotnet test ./test/Dapper.FluentMap.Tests/Dapper.FluentMap.Tests.csproj | ||
| --configuration Release --no-build | ||
|
|
||
| provider-clients: | ||
| name: Experimental latest provider clients | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 25 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6 | ||
| with: | ||
| global-json-file: global.json | ||
|
|
||
| - name: Restore latest stable provider clients | ||
| run: >- | ||
| dotnet restore ./test/Dapper.FluentMap.ProviderCompatibility.Tests/Dapper.FluentMap.ProviderCompatibility.Tests.csproj | ||
| -p:SqlClientPackageVersion=* | ||
| -p:SqliteClientPackageVersion=* | ||
| -p:MySqlConnectorPackageVersion=* | ||
| -p:NpgsqlPackageVersion=* | ||
|
|
||
| - name: Report resolved experimental clients | ||
| shell: pwsh | ||
| run: | | ||
| $assets = Get-Content -Raw './test/Dapper.FluentMap.ProviderCompatibility.Tests/obj/project.assets.json' | ConvertFrom-Json | ||
| $packages = @('Microsoft.Data.SqlClient/', 'Microsoft.Data.Sqlite/', 'MySqlConnector/', 'Npgsql/') | ||
| foreach ($prefix in $packages) { | ||
| $resolved = @($assets.libraries.PSObject.Properties.Name | Where-Object { $_ -like "$prefix*" }) | ||
| "- experimental: $($resolved -join ', ')" >> $env:GITHUB_STEP_SUMMARY | ||
| } | ||
|
|
||
| - name: Build against experimental clients | ||
| run: >- | ||
| dotnet build ./test/Dapper.FluentMap.ProviderCompatibility.Tests/Dapper.FluentMap.ProviderCompatibility.Tests.csproj | ||
| --configuration Release --no-restore | ||
| -p:SqlClientPackageVersion=* | ||
| -p:SqliteClientPackageVersion=* | ||
| -p:MySqlConnectorPackageVersion=* | ||
| -p:NpgsqlPackageVersion=* | ||
|
|
||
| - name: Run always-available SQLite evidence | ||
| env: | ||
| DFM_PROVIDER_FILTER: SQLite | ||
| run: >- | ||
| dotnet ./test/Dapper.FluentMap.ProviderCompatibility.Tests/bin/Release/net10.0/Dapper.FluentMap.ProviderCompatibility.Tests.dll | ||
| -failSkips -parallelMode none |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| name: Performance Regression Report | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "19 9 * * 3" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: performance-report-${{ github.repository }} | ||
| cancel-in-progress: false | ||
|
|
||
| env: | ||
| DOTNET_CLI_TELEMETRY_OPTOUT: "true" | ||
| DOTNET_SKIP_FIRST_TIME_EXPERIENCE: "true" | ||
|
|
||
| jobs: | ||
| materialization: | ||
| name: Materialization hot paths (report only) | ||
| runs-on: windows-latest | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6 | ||
| with: | ||
| global-json-file: global.json | ||
|
|
||
| - name: Restore benchmark project | ||
| run: dotnet restore ./benchmarks/Dapper.FluentMap.Benchmarks/Dapper.FluentMap.Benchmarks.csproj | ||
|
|
||
| - name: Build benchmark project | ||
| run: dotnet build ./benchmarks/Dapper.FluentMap.Benchmarks/Dapper.FluentMap.Benchmarks.csproj --configuration Release --no-restore | ||
|
|
||
| - name: Run materialization benchmark report | ||
| run: >- | ||
| dotnet run --project ./benchmarks/Dapper.FluentMap.Benchmarks/Dapper.FluentMap.Benchmarks.csproj | ||
| --configuration Release --no-build -- | ||
| --filter "*DapperWithFluentMapRootMapping*" "*QueryMappedSimple" "*RuntimeQueryMappedSimple" | ||
| "*RuntimeQueryGeneratedSimpleExtraColumn*" "*QueryMappedGeneratedPropertyConverter*" | ||
| "*QueryMappedTwoSegments*" "*QueryMappedThreeSegments*" | ||
| --exporters fulljson | ||
|
|
||
| - name: Capture benchmark run metadata | ||
| shell: pwsh | ||
| env: | ||
| BENCHMARK_COMMAND: >- | ||
| dotnet run --project ./benchmarks/Dapper.FluentMap.Benchmarks/Dapper.FluentMap.Benchmarks.csproj | ||
| --configuration Release --no-build -- | ||
| --filter "*DapperWithFluentMapRootMapping*" "*QueryMappedSimple" "*RuntimeQueryMappedSimple" | ||
| "*RuntimeQueryGeneratedSimpleExtraColumn*" "*QueryMappedGeneratedPropertyConverter*" | ||
| "*QueryMappedTwoSegments*" "*QueryMappedThreeSegments*" | ||
| --exporters fulljson | ||
| COMMIT_SHA: "${{ github.sha }}" | ||
| RUNNER_NAME: "${{ runner.name }}" | ||
| RUNNER_OS: "${{ runner.os }}" | ||
| RUNNER_ARCH: "${{ runner.arch }}" | ||
| run: | | ||
| New-Item -ItemType Directory -Force -Path './artifacts/benchmark-report' | Out-Null | ||
| $metadata = [ordered]@{ | ||
| command = $env:BENCHMARK_COMMAND | ||
| commit = $env:COMMIT_SHA | ||
| runner = [ordered]@{ | ||
| name = $env:RUNNER_NAME | ||
| os = $env:RUNNER_OS | ||
| architecture = $env:RUNNER_ARCH | ||
| } | ||
| dotnetInfo = ((dotnet --info) -join [Environment]::NewLine) | ||
| } | ||
| $metadata | ConvertTo-Json -Depth 4 | | ||
| Set-Content -LiteralPath './artifacts/benchmark-report/run-metadata.json' -Encoding utf8 | ||
|
|
||
| - name: Compare with checked-in baseline | ||
| shell: pwsh | ||
| run: | | ||
| $result = Get-ChildItem './.tmp/benchmarks/BenchmarkDotNet.Artifacts/results/*-report-full.json' | | ||
| Select-Object -First 1 | ||
| if ($null -eq $result) { | ||
| throw 'BenchmarkDotNet JSON output was not produced.' | ||
| } | ||
| ./eng/compare-benchmark-results.ps1 ` | ||
| -BaselinePath './benchmarks/baselines/materialization-windows-net10.json' ` | ||
| -CurrentPath $result.FullName ` | ||
| -OutputDirectory './artifacts/benchmark-report' | ||
| Get-Content './artifacts/benchmark-report/benchmark-comparison.md' >> $env:GITHUB_STEP_SUMMARY | ||
|
|
||
| - name: Upload benchmark evidence | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 | ||
| with: | ||
| name: materialization-benchmark-report | ||
| path: | | ||
| ./.tmp/benchmarks/BenchmarkDotNet.Artifacts/results/* | ||
| ./artifacts/benchmark-report/* | ||
| if-no-files-found: error | ||
| retention-days: 90 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.