Fix dune runtest by moving utils expect tests to Alcotest - #375
Open
lykimq wants to merge 3 commits into
Open
Conversation
include_subdirs break expect correction paths and crashes dune runtest; drop the inline tests (and the print-only Git_utils helper) from the library
Move the former expect cases into tests/ so dune runtest and CI exercise them.
Zimmi48
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ppx_expectinline tests fromGit_utils/String_utils(they crash underinclude_subdirswhen writing corrected files).inline_tests/ppx_expectfrombot-components.tests/test_git_utils.mlandtests/test_string_utils.ml.dune build @runtestinstead ofdune build @tests/runtestReason:
dune runtestfailed withSys_errorlooking forGit_utils.ml/String_utils.mlat the library root instead ofutils/.CI only ran
@tests/runtest, so this was easy to miss.