Split codehelper code fixes into separate assembly#135
Merged
Conversation
ThadHouse
force-pushed
the
split-codefix-project
branch
2 times, most recently
from
45b9087 to
4bc4053
Compare
ThadHouse
force-pushed
the
split-codefix-project
branch
from
4bc4053 to
95eef96
Compare
# Conflicts: # Directory.Packages.props # codehelp/CodeHelpers.Core/WPILib.CodeHelpers.Core.csproj # codehelp/CodeHelpers.Test/CodeHelpers.Test.csproj # src/Directory.Build.props
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96ef7ee0f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the codehelper compiler extensions so Roslyn 5 extended analyzer rules do not require suppressing RS1038.
WPILib.CodeHelpersas the common analyzer/shared assembly with onlyMicrosoft.CodeAnalysis.CommonWPILib.CodeHelpers.CodeFixesValidation
dotnet build WPILib.sln --no-restore -v:minimaldotnet test codehelp/CodeHelpers.Test/CodeHelpers.Test.csproj --no-restore -v:minimaldotnet test WPILib.sln --no-restore -v:minimalNotes
This PR is based on
dotnet10because it depends on the Roslyn/package updates from that branch.