fix: return error instead of panic for TZ= without space#566
Open
Yanhu007 wants to merge 1 commit into
Open
Conversation
ParseStandard("TZ=0") panics because strings.Index(spec, " ")
returns -1 when there is no space after the timezone, causing
spec[eq+1 : -1] to panic with a slice bounds out of range error.
Check for i == -1 and return a descriptive error instead.
Fixes robfig#554
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #554
Problem
cron.ParseStandard("TZ=0")panics withslice bounds out of rangebecausestrings.Index(spec, " ")returns-1when there is no space after the timezone prefix, causingspec[eq+1 : -1]to panic.This is dangerous in production when user-provided cron expressions are parsed.
Fix
Check if the space index is
-1and return a descriptive error instead of panicking.Test
All existing tests pass.