Repository navigation
Conversation
added 2 commits
October 19, 2026 17:18
Signed-off-by: Osvaldas Beniušis <osvaldas.beniusis@eneba.com>
Signed-off-by: Osvaldas Beniušis <osvaldas.beniusis@eneba.com>
Nyholm
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for This PR
RFC 7239 requires an IPv6 node in
Forwardedto be bracketed and quoted, also without a port:for="[2001:db8:cafe::17]".parseForwardedtrims the quotes but keeps the brackets, soRemoteAddrbecomes[2001:db8:cafe::17]. That is neitherhost:portnor an IP, so the http plugin'sFetchIPlogsremote address parsing failure ... missing port in addressand PHP receives an emptyREMOTE_ADDR.We hit this in production behind a trusted proxy: affected requests reached the application with an empty client IP.
Description of Changes
parseForwardedstrips the brackets from a bracketed IPv6 node that has no port.[v6]:portis returned unchanged, as before.TestIPand an end-to-end case inTestForwarded. Againstmasterthe latter fails withexpected: "2001:db8:cafe::17", actual: "".License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
git commit -s).CHANGELOG.md(generated by release-please from the commit title).