Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/graphql/schema/build_from_definition.rb
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ def build(schema_superclass, document, default_resolve:, using: {}, base_types:
replace_late_bound_types_with_built_in(types)

schema_extensions = nil
definitions_by_name = nil
document.definitions.each do |definition|
case definition
when GraphQL::Language::Nodes::SchemaDefinition, GraphQL::Language::Nodes::DirectiveDefinition
Expand All @@ -101,9 +102,16 @@ def build(schema_superclass, document, default_resolve:, using: {}, base_types:
if prev_type.nil? || prev_type.is_a?(Schema::LateBoundType)
if definition.is_a?(GraphQL::Language::Nodes::ObjectTypeDefinition) || definition.is_a?(Language::Nodes::InterfaceTypeDefinition)
interface_names = definition.interfaces.map(&:name)
transitive_names = interface_names.map { |n| document.definitions.find { |d| d.respond_to?(:name) && d.name == n }&.interfaces&.map(&:name) }
transitive_names.flatten!
transitive_names.compact!
if !interface_names.empty?
definitions_by_name ||= document.definitions.each_with_object({}) do |d, by_name|
by_name[d.name] ||= d if d.respond_to?(:name)
end
transitive_names = interface_names.map { |n| definitions_by_name[n]&.interfaces&.map(&:name) }
transitive_names.flatten!
transitive_names.compact!
else
transitive_names = interface_names
end
if !(missing_transitive_interfaces = transitive_names - interface_names).empty?
raise GraphQL::Schema::InvalidDocumentError, "type #{definition.name} is missing one or more transitive interface names: #{missing_transitive_interfaces.join(", ")}. Add them to the type's `implements` list and try again."
end
Expand Down
Loading