Forward Relay subscription errors - #5674
Merged
rmosolgo merged 1 commit intoJul 23, 2026
Merged
Conversation
Owner
|
Oops, it was probably supposed to be |
Owner
|
🚢 in graphql-ruby-client v1.15.2 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Relay subscription errors being silently discarded.
The shared Relay subscription handler referenced
observer.errorwithout calling it. This prevented errors from reaching Relay consumers using ActionCable, Pusher, or Ably. This change callsobserver.error(error)and adds regression coverage verifying that transport errors are forwarded unchanged to the Relay observer.