refactor: separate transition evaluation from commit - #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Refactored transition execution so preview and committed execution share the same internal transition evaluation path.
Changes:
Engine.step()to evaluate transitions first, then commit the resulting state.preview()to consume the same evaluation path instead of using snapshot, mutate, and restore behavior.export_json()/import_json()round-tripping.Why the change was needed
preview()previously evaluated transitions by temporarily mutating the engine through the normal execution path and restoring the original state afterward.Although behavior was preserved, this coupled audit/preview behavior to mutation and persistence mechanisms.
The new structure separates:
This keeps preview non-mutating, ensures preview and execution share the same transition semantics, and creates a cleaner internal boundary for future transition metadata.
Checklist
uv run pre-commit run --all-files)uv run pytest)Closes #220
This refactor establishes the internal transition evaluation boundary that may support future transition metadata/diagnostics (#199), but does not implement diagnostics.