Repository navigation
fix(deploy): wait for the new build before reporting the rollout - #41
Merged
Merged
Conversation
Right after the pool PUT, Rivet Cloud can still return the pool status from before it, with the new build_id. Deploy read that old status as the result: a false success for a new build, and a false failure for a rollback from a degraded pool. A status now counts only after the pool was seen rolling, or when it differs from the status read before the PUT. The rest of the wait follows rivet deploy: nodes updated and ready, and degraded or down fails only when action_needed. A redeploy that changes nothing takes the current status. The rollback hint names the previous build only if it was ready.
|
Preview removed; R2 assets deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right after the pool PUT, Rivet Cloud can still return the pool status from before it, already with the new
build_id.orange deployread that old status as the result.Pool status read 2 s after a PUT on a real cluster:
Same cluster,
orange deploy --build <id>:main✓ Deployed3 s after the PUT. The pool wasupdatingfor 81 s more.✓when the pool isreadyon it✓ Deployed, exit 0degraded (user fault): … App keeps exiting, exit 1,Roll back with: … --build <previous good build>Build <good> failed,Roll back with: … --build <crashing build>✓ Deployed✓in 3 swait_for_rolloutinrivet deploy(engine/packages/cli/src/commands/deploy/cluster.rs): the pool must stay on the build, every node updated and ready, anddegradedordownfails only whenaction_neededis set.readyon it.