Skip to content

fix(deploy): retry dropped uploads and show upload progress - #40

Merged
eersnington merged 1 commit into
mainfrom
feat/deploy-upload-progress-retry
Nov 16, 2026
Merged

eersnington merged 1 commit into
mainfrom
feat/deploy-upload-progress-retry

Conversation

@eersnington

@eersnington eersnington commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

A dropped connection during the image upload failed orange deploy and offered a bug report. On a slow link this can happen after a long upload.

Same drop on a real cluster: one TCP reset on the upload socket, 192.1 MiB image.

main:

Uploading build 26db962f-… (192.1 MiB)…
Failed to upload the image: read ECONNABORTED
Looks like a bug? Report it: https://github.com/rivet-dev/open-orange/issues/new?…

This PR:

Uploading build 8c4ff5d8-… (192.1 MiB)…
Upload attempt 1 failed. The connection failed: read ECONNABORTED. Retrying in 1 s…
Preparing build 8c4ff5d8-…. This takes a few minutes…

Rivet Cloud then reported build 8c4ff5d8 as ready, so the retried upload was complete.

  • uploadFile sends the file again to the same signed URL, up to 3 attempts, 1 s and 3 s apart. It retries on connection loss, 408, 429 and 5xx.
  • Cloud API GET and PUT calls retry the same way. POST calls (createBuild, completeBuild, secret rollout) are sent once: if Rivet Cloud acted and only the answer was lost, a second POST would create a second build.
  • Out of attempts, the error says to check the connection and has no bug report link.
  • In a terminal, the spinner shows bytes sent and the rate.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Preview removed; R2 assets deleted.

A dropped connection during the image upload failed the deploy with a
bug report link. The upload now gets 3 attempts, and so do Cloud API GET
and PUT calls. POST calls are sent once, because a lost answer to a POST
that already reached Rivet Cloud would create a second build if repeated.
In a terminal, the spinner shows bytes sent and the upload rate.
@eersnington
eersnington force-pushed the feat/deploy-upload-progress-retry branch from bab9d34 to 95c1181 Compare November 16, 2026 19:50
@eersnington
eersnington merged commit 6eaa45d into main Nov 16, 2026
11 checks passed
@eersnington
eersnington deleted the feat/deploy-upload-progress-retry branch November 16, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant