Repository navigation
fix(deploy): retry dropped uploads and show upload progress - #40
Merged
Merged
Conversation
|
Preview removed; R2 assets deleted. |
A dropped connection during the image upload failed the deploy with a bug report link. The upload now gets 3 attempts, and so do Cloud API GET and PUT calls. POST calls are sent once, because a lost answer to a POST that already reached Rivet Cloud would create a second build if repeated. In a terminal, the spinner shows bytes sent and the upload rate.
eersnington
force-pushed
the
feat/deploy-upload-progress-retry
branch
from
November 16, 2026 19:50
bab9d34 to
95c1181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dropped connection during the image upload failed
orange deployand offered a bug report. On a slow link this can happen after a long upload.Same drop on a real cluster: one TCP reset on the upload socket, 192.1 MiB image.
main:This PR:
Rivet Cloud then reported build
8c4ff5d8asready, so the retried upload was complete.uploadFilesends the file again to the same signed URL, up to 3 attempts, 1 s and 3 s apart. It retries on connection loss, 408, 429 and 5xx.createBuild,completeBuild, secret rollout) are sent once: if Rivet Cloud acted and only the answer was lost, a second POST would create a second build.