Repository navigation
fix(dev): stop the Rivet Engine when the terminal closes - #34
Merged
Merged
Conversation
Closing the terminal sends SIGHUP to orange dev and its runtime. Node's default exits at once, so the Engine, in its own process group, kept running and the next orange dev reused it. Treat SIGHUP as a stop request in both processes. A repeated SIGHUP or an EIO write to the closed terminal only starts a stop, so it can no longer force-kill the runtime before it stops the Engine.
eersnington
force-pushed
the
fix/dev-sighup-engine
branch
from
November 14, 2026 21:54
6fca89e to
20c6421
Compare
|
Preview removed; R2 assets deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the terminal that runs
orange devleft the local Rivet Engine running with PPID 1. The nextorange devreused it without a message. Ctrl-C and SIGTERM already stopped it.A closed terminal stopped the Engine stop in three ways:
dev-session.tsandrunner.tsstop()in the runtime runs once and a second call waits for the EngineEIOEIOcrashes the CLI, or as a closed output it raises a second, forcing stopclosed-output.tshandlesEIOlikeEPIPE, and a closed output only starts a stopprocess-protocol.tsadds"SIGHUP"as a stop reason.tests/orange-dev.tscan runorange devon a real pty (script(1)) and hang it up.