Skip to content

fix(runtime): prefer host type flags over mode bits in Stats #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wasaybuilds wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −7
Open

fix(runtime): prefer host type flags over mode bits in Stats #1909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions packages/build-tools/bridge-src/builtins/fs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,20 @@ var O_EXCL = 128;
var O_TRUNC = 512;
var O_APPEND = 1024;
var KERNEL_POLLIN = 1;
// Host stat payloads carry explicit `isDirectory` / `isSymbolicLink` flags that
// reflect what the VFS actually resolved. Prefer them over the mode bits, which
// can disagree on backends with stale attribute caches (e.g. NFS/EFS), and fall
// back to the mode bits when a backend omits the hints.
function resolveStatFormat(init) {
const fmt = init.mode & 61440;
const isDir = typeof init.isDirectory === "boolean" ? init.isDirectory : void 0;
const isLink = typeof init.isSymbolicLink === "boolean" ? init.isSymbolicLink : void 0;
if (isLink === true) return 40960;
if (isDir === true) return 16384;
if (isDir === false && fmt === 16384) return 32768;
if (isLink === false && fmt === 40960) return 32768;
return fmt;
}
var Stats = class {
dev;
ino;
Expand Down Expand Up @@ -56,27 +70,31 @@ var Stats = class {
this.mtime = new Date(this.mtimeMs);
this.ctime = new Date(this.ctimeMs);
this.birthtime = new Date(this.birthtimeMs);
Object.defineProperty(this, "_typeFormat", {
value: resolveStatFormat(init),
enumerable: false
});
}
isFile() {
return (this.mode & 61440) === 32768;
return this._typeFormat === 32768;
}
isDirectory() {
return (this.mode & 61440) === 16384;
return this._typeFormat === 16384;
}
isSymbolicLink() {
return (this.mode & 61440) === 40960;
return this._typeFormat === 40960;
}
isBlockDevice() {
return (this.mode & 61440) === 24576;
return this._typeFormat === 24576;
}
isCharacterDevice() {
return (this.mode & 61440) === 8192;
return this._typeFormat === 8192;
}
isFIFO() {
return (this.mode & 61440) === 4096;
return this._typeFormat === 4096;
}
isSocket() {
return (this.mode & 61440) === 49152;
return this._typeFormat === 49152;
}
};
var Dirent = class {
Expand Down