Skip to content

fix(rivetkit): add serverless request validation #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanFlurry wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

fix(rivetkit): add serverless request validation #5608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rivetkit-rust/packages/rivetkit-core/src/registry/envoy_callbacks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,9 @@ impl ServeConfig {
serverless_client_token: settings.serverless_client_token,
serverless_validate_endpoint: settings.serverless_validate_endpoint,
serverless_max_start_payload_bytes: settings.serverless_max_start_payload_bytes,
serverless_cache_envoy: true,
// TODO: Flip this back to true. Currently disabled because we need a unique
// connection to verify the serverless token.
serverless_cache_envoy: false,
..Default::default()
}
}
Expand Down
8 changes: 6 additions & 2 deletions rivetkit-typescript/packages/rivetkit-napi/src/registry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,9 @@ impl CoreRegistry {
}
};

let serve_config = serve_config_from_js(config, false, true);
// TODO: Flip this back to true. Currently disabled because we need a unique
// connection to verify the serverless token.
let serve_config = serve_config_from_js(config, false, false);
*self.route_package_version.lock() = Some(serve_config.serverless_package_version.clone());
*self.route_metadata.lock() = Some(metadata_response(
registry.normal_metadata_payload(&serve_config),
Expand Down Expand Up @@ -635,7 +637,9 @@ impl CoreRegistry {
registry: NativeCoreRegistry,
config: JsServeConfig,
) -> napi::Result<CoreServerlessRuntime> {
let serve_config = serve_config_from_js(config, true, true);
// TODO: Flip this back to true. Currently disabled because we need a unique
// connection to verify the serverless token.
let serve_config = serve_config_from_js(config, true, false);
*self.route_package_version.lock() = Some(serve_config.serverless_package_version.clone());
*self.route_metadata.lock() = Some(metadata_response(
registry.serverless_metadata_payload(&serve_config),
Expand Down
Loading