Skip to content

fix(rivetkit-napi): remove stale HttpRequestBodyStream test after envoy v6 revert #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abcxff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rivetkit-napi): remove stale HttpRequestBodyStream test after envoy v6 revert #5604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 1 addition & 24 deletions rivetkit-typescript/packages/rivetkit-napi/tests/actor_factory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,10 @@ mod moved_tests {

use parking_lot::Mutex;
use rivet_error::{MacroMarker, RivetError, RivetErrorSchema};
use rivetkit_core::HttpRequestBodyStream as CoreHttpRequestBodyStream;
use tokio::sync::{mpsc, watch};
use tracing::Level;
use tracing_subscriber::fmt::MakeWriter;

use super::{BRIDGE_RIVET_ERROR_PREFIX, HttpRequestBodyStream, parse_bridge_rivet_error};
use super::{BRIDGE_RIVET_ERROR_PREFIX, parse_bridge_rivet_error};

static AUTH_FORBIDDEN_SCHEMA: RivetErrorSchema = RivetErrorSchema {
group: "auth",
Expand Down Expand Up @@ -126,25 +124,4 @@ mod moved_tests {
assert!(logs.contains("malformed BridgeRivetErrorPayload"));
assert!(logs.contains("parse_err"));
}

#[tokio::test]
async fn cancelling_http_request_body_drops_core_receiver() {
let (body_tx, body_rx) = mpsc::channel(1);
let (_abort_tx, abort_rx) = watch::channel(None);
let stream = HttpRequestBodyStream::new(
Vec::new(),
CoreHttpRequestBodyStream::new(body_rx, abort_rx),
);

stream.cancel().await.expect("cancel request body stream");

assert!(body_tx.is_closed());
assert!(
stream
.read()
.await
.expect("read cancelled request body")
.is_none()
);
}
}
Loading