Fixed: Fermata encoding#205
Open
ahankinson wants to merge 2 commits into
Open
Conversation
Clarifies that fermatas are available on rests and measure rests Re-works the fermata section to point to how to encode them on notes, rests, and chords. Fixed #202
|
lpugin
reviewed
May 28, 2026
ahankinson
added
the
Type: Spec Clarification
BaMikusi
reviewed
May 28, 2026
| The lower-case character <code>p</code> is used to indicate a fermata. | ||
| </p> | ||
| <p> | ||
| For notes, the <code>p</code> MUST immediately follow the note name; however, If there is also |
Collaborator
There was a problem hiding this comment.
Instead of "; however, if there is also" It would sound better to say in a single sentence "unless there is also (...) in which case"
BaMikusi
reviewed
May 28, 2026
Comment on lines
+2063
to
+2070
| a <a href="#trills">trill</a>, the <code>p</code> MUST follow the trill character. | ||
| </p> | ||
| <p> | ||
| For rests, see the <a href="#single-rests">single rests</a> section for how fermatas are encoded. | ||
| For multi-measure rests, see the <a href="#measure-rests">measure rests</a> section for details. | ||
| </p> | ||
| <p> | ||
| For chords, see the <a href="#chords">chords</a> section for how fermatas are encoded. |
Collaborator
There was a problem hiding this comment.
This is all quite clumsy -- perhaps better pull it together into a single sentence? I mean something ike this: "For the use of fermatas on rests, multi-measure rests, and chords, see the sections on single rests, measure rests, and chords, respectively."
BaMikusi
reviewed
May 28, 2026
| </p> | ||
| <p> | ||
| A <a href="#fermatas">fermata</a> for a measure rest MAY be supplied. If provided, the <code>p</code> | ||
| MUST immediately follow the <code>=</code>, or, if given, MUST immediately follow the number of |
Collaborator
There was a problem hiding this comment.
Alternatively: "or, if the number of bars is specified, MUST immediately follow this number."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies that fermatas are available on rests and measure rests Re-works the fermata section to point to how to encode them on notes, rests, and chords.
Fixed #202