Fixed: shortcuts section#186
Merged
Merged
Conversation
Since this can also apply to other shortcuts as well, better to put it at the top of the section.
Since many notation figures use and refer to the duration section, rhythmic sequences should be considered a sub-definition of duration, rather than an independent encoding. It also does not introduce any new encoding characters, but instead offers an alternative to how the durations can be applied.
|
Contributor
Author
|
OK, I have expanded and clarified the duration pattern prose, and fixed up other terminology in the spec that may have been inconsistent. |
lpugin
reviewed
May 14, 2026
lpugin
reviewed
May 14, 2026
Contributor
Author
|
How about this paragraph, to replace the current one:
|
Also remove the restriction on ending at a staff definition change.
lpugin
reviewed
May 15, 2026
BaMikusi
reviewed
May 18, 2026
BaMikusi
reviewed
May 18, 2026
lpugin
reviewed
May 18, 2026
Co-authored-by: Laurent Pugin <lxpugin@gmail.com>
lpugin
reviewed
May 28, 2026
Also formatting of the shortcuts setting
lpugin
reviewed
May 28, 2026
lpugin
reviewed
May 28, 2026
Co-authored-by: Laurent Pugin <lxpugin@gmail.com>
…rism-digital/pae-code-spec into fixed-shortcuts
lpugin
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and normalizes the shortcuts section. This is intended primarily as a clarification, not as introducing any new rules.
The rhythmic repeat was moved as a sub-section to the Duration section. Since this can apply in several places, it made more sense to define it as a variation of duration encoding, rather than its own standalone shortcut. It also introduces no new characters for encoding, and instead offers an alternative to how the durations can be applied. It also simplifies references to this, as any logical unit that refers to a duration can also be assumed to allow rhythmic sequences as well.
Also clarifies #132