feat: 2/7 add role membership read contract#25522
Open
tabVersion wants to merge 1 commit intoralph/rbac-split-01-parser-surfacefrom
Open
feat: 2/7 add role membership read contract#25522tabVersion wants to merge 1 commit intoralph/rbac-split-01-parser-surfacefrom
tabVersion wants to merge 1 commit intoralph/rbac-split-01-parser-surfacefrom
Conversation
This PR adds the storage and read API contract needed before role grant and revoke behavior can become authoritative. It keeps grant and revoke RPCs out of the contract layer while adding the compile-coupled inherit flag and list membership surfaces.\n\nConstraint: Generated service traits require every added RPC to compile through meta service, RPC client, frontend client, and mocks.\nRejected: Add GrantRole and RevokeRole RPCs in this contract PR | would require behavior stubs before the authoritative controller implementation lands.\nConfidence: high\nScope-risk: moderate\nDirective: Keep write behavior out of this PR; grant and revoke RPCs belong with their meta implementations.\nTested: cargo fmt; cargo fmt --check; cargo check -p risingwave_meta -p risingwave_rpc_client -p risingwave_frontend\nNot-tested: Runtime migration/restore path against a live cluster
github-actions
Bot
added
Invalid PR Title
ci/run-backwards-compat-tests
7 tasks
tabVersion
changed the title
github-actions
Bot
added
type/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 2/7 for splitting
ralph/rbac-postgres-final-alignmentontoorigin/main.Base:
ralph/rbac-split-01-parser-surfaceNext:
ralph/rbac-split-03-meta-grant-authorityScope
RoleMembership,ListRoleMemberships, migrations/entity, backup/restore parity, and client/service list passthrough.UserInfo.can_inherit/UpdateField::INHERIT, including defaultcan_inherit = truefor created users/fixtures.Out of scope
GrantRoleandRevokeRoleRPCs and behavior.Tests
cargo fmt --checkcargo check -p risingwave_meta -p risingwave_rpc_client -p risingwave_frontend