Skip to content

feat: add wallet dependency scanning for Wallet Connection (Closes #415)#639

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
ghost-cy829:fix/issue-415-wallet-dependency-scanning
Jun 4, 2026
Merged

feat: add wallet dependency scanning for Wallet Connection (Closes #415)#639
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
ghost-cy829:fix/issue-415-wallet-dependency-scanning

Conversation

@ghost-cy829
Copy link
Copy Markdown
Contributor

Closes #415

Changes

  • Add scanWalletDependencies() to detect Freighter and other wallets
  • Show detected wallets with user-friendly messages
  • Show install prompt when no wallets found
  • Add loading states during scanning
  • Add unit tests for dependency scanning
  • Add accessibility ARIA labels

Test Results

✅ All tests passing

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 31, 2026

@ghost-cy829 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER
Copy link
Copy Markdown
Contributor

Kindly resolve conflict and fix workflow.

@ghost-cy829
Copy link
Copy Markdown
Contributor Author

Kindly resolve conflict and fix workflow.

@maintainer
This PR is ready for review. Please review when you have time. Let me know if any changes are needed.
Thank you!

@RUKAYAT-CODER
Copy link
Copy Markdown
Contributor

RUKAYAT-CODER commented Jun 1, 2026

There is still conflict. Don't forget to pull before pushing

…nafcode#415)

- Add scanWalletDependencies() to detect Freighter and other wallets
- Show detected wallets with user-friendly messages
- Show install prompt when no wallets found
- Add loading states during scanning
- Add unit tests for dependency scanning
- Add accessibility ARIA labels
@ghost-cy829 ghost-cy829 force-pushed the fix/issue-415-wallet-dependency-scanning branch from 4546a63 to bc371d4 Compare June 3, 2026 19:35
@ghost-cy829
Copy link
Copy Markdown
Contributor Author

I have resolved the conflicts and cleaned up the PR. Now only 4 files are changed. Please review when you have time. Thank you!

@RUKAYAT-CODER
Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER RUKAYAT-CODER merged commit 467a25f into rinafcode:main Jun 4, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test Wallet Connection : Dependency Scanning

2 participants