Conversation
tarr1124
marked this pull request as ready for review
September 14, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rill's skill tests could report success after child assertions failed, Codex write hooks did not consistently parse actual tool inputs or return blocking exit codes, and legacy/plugin commands could be projected as skills without required metadata. This change propagates failures, normalizes hook targets and denials, and generates thin metadata-bearing skill wrappers while preserving user-owned files and source resources.
Adds an opt-in real-CLI comparison runner with fresh synthetic vaults, explicit models, structured run records, independent expectations, original-file and duplicate checks, timeouts, and contamination monitoring. Copies only allowlisted tracked deployment inputs, includes container schemas, and excludes local plugin configuration/state. Raw logs stay local; ordinary CI makes no model calls.
Validation:
CI: all four jobs passed at 46ac69c (Ubuntu, macOS, lint, guard).
Scope: PR only; no merge or production-vault update. The small cases establish functional behavior, not statistical model quality. Live runs do not bypass hook trust; exact hook inputs, exit codes and post-write effects are covered separately by deterministic replay tests.