retrospective-interactive-finalize: interactive Self Observation approval - #83
Merged
Merged
Conversation
… interactively Editing checkboxes in the report file from a terminal session proved high-friction. --finalize now presents unchecked candidates as multi-select questions and writes the [x] marks on the user's behalf; the file checkbox stays the durable record and manual marking remains a fallback. Bare --finalize sweeps all pending periods (oldest first) and clusters near-duplicate candidates across periods. Unattended runs never block: they process pre-marked lines only. Phase 4 now offers the approval right after generation while context is hot. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…back Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tarr1124
added a commit
that referenced
this pull request
Aug 10, 2026
Claude Code stamps every commit with "Co-Authored-By: ... <noreply@anthropic.com>", and GitHub squash merges add "Co-authored-by: ... <user@users.noreply.github.com>". The commit-message scan (--stdin) has no allowlist, so every Claude-authored PR failed CI (first seen on PR #83). Add a full-match-anchored built-in exemption for exactly these two address shapes in both modes; lookalikes that extend the local part or swap the domain still fail, and phone/secret hits are never exempt. The tree-mode remainder rescan honors the same exemption so a safe address sharing a line with an allowlisted placeholder stays clean. Adds test/cli/test-pii-regex-guard.sh (16 cases) covering the exemption, its anchoring, and unchanged behavior for personal emails, phones, and secrets; wires it into test/run-all.sh. Co-authored-by: tarr1124 <tarr1124@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--finalizenow collects Self Observation approval interactively: unchecked candidates are presented as multi-select questions and the skill writes the[x]marks on the user's behalf. Editing checkboxes in a report file from a terminal session was high-friction.--finalize(no period) sweeps every period in the state sidecar'spending_finalize, oldest first, clustering near-duplicate candidates across periods before asking.[x]+--finalize {period}stays supported.claude -p, cron) never block: pre-marked lines only, otherwise report-and-exit.Verification
🤖 Generated with Claude Code