Skip to content

fix: respect custom time range setting in Canvas dashboards#9510

Merged
djbarnwal merged 1 commit into
mainfrom
fix/custom-range-selector-canvas
May 29, 2026
Merged

fix: respect custom time range setting in Canvas dashboards#9510
djbarnwal merged 1 commit into
mainfrom
fix/custom-range-selector-canvas

Conversation

@djbarnwal
Copy link
Copy Markdown
Member

  • Applies allow_custom_time_range from the resolved Canvas spec to the Canvas time manager
  • Passes the setting through to the Canvas comparison pill so custom comparison ranges are also hidden when disabled

Canvas dashboards parsed allow_custom_time_range: false correctly, but the frontend time manager never loaded that value from the Canvas spec. As a result, Canvas time controls kept using the default true behavior and still showed custom range options.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@djbarnwal djbarnwal requested a review from AdityaHegde May 28, 2026 15:32
@djbarnwal djbarnwal merged commit ba12203 into main May 29, 2026
16 checks passed
@djbarnwal djbarnwal deleted the fix/custom-range-selector-canvas branch May 29, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants