Conversation
Collaborator
Author
|
Closing this draft: the feature is still wanted, this head is not the way to it. The branch Why closed rather than continued:
Nothing was superseded: no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source freeze: 10 code files + 0 regenerated baseline files = 10 files, 433 changed lines. The coordinator-authorized exception permits the reviewed final baseline set up to 19 files; replace this line with actual final counts after adoption.
LCD Power, SWR and ALC previously had text readings without persistent printed scales. Add one passive 20-segment LCD component across Peer, Dominant, Centerstage and Panadapter. Supported scales retain their DOM while RX shows empty IDLE, stale/missing observations remain empty with their cue, and current readings use canonical capability calibration and honest units, including zero and raw values. The full shared TX display facet remains authoritative; VD/ID/COMP output is preserved.
Keep labels and ordinary readouts at least 8 effective pixels, with a 7px minimum for long honest readouts such as
255 raw ?. Reserve the declared native stage floor and frame border in the LCD shell. Sidebars retain 228px preferred width, shrink to a usable 216px floor, then the entire constrained row scrolls horizontally. Native canvases and proportions are unchanged; 1280 primary geometry is exact, while 1100 gains the small uniform scale/position adjustment required to show the whole stage. Cockpit/scope keep their existing grid.Validation: 316 focused tests (301 meter/display cases plus 15 existing LCD-layout controls), 22 fixture browser checks, Svelte/TypeScript checks and focused lint passed. Browser checks explicitly load the bundled font and measure actual text Range widths, effective text size, honest long values, clipping ancestors, native geometry, sidebar control/label containment, focus/hit testing and real horizontal wheel scrolling at 1000/760. Eight shell mutations and six earlier readability mutations were detected; equivalent controls passed. No full local suite or hardware validation.
Pending before ready: exact Linux artifact inspection and conditional baseline adoption, final counts above, exact-head CI and independent review. MOR-1413 operator acceptance remains open; the 7px long-readout edge is explicit.
Current Linux validation is FAILED (test_failure): regeneration run 33993832517 at 9eadd81 passed 51/53 tests but failed both Dominant long-readout cases. The logged loaded-font text Range for
10000W ?exceeds its available width (44.9583 vs 42.8704px at 1280; 36.0146 vs 34.3420px at 1100). Local results above are macOS-only and do not establish Linux fit. No generated PNG or manifest has been adopted. The bounded correction cycle is stopped; this PR stays Draft pending a revised plan and owner continuation.