Skip to content

feat(MOR-2372): add persistent calibrated LCD TX scales - #3226

Closed
morozsm wants to merge 3 commits into
mainfrom
codex/mor2372-lcd-tx-scales
Closed

morozsm wants to merge 3 commits into
mainfrom
codex/mor2372-lcd-tx-scales

Conversation

@morozsm

@morozsm morozsm commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Source freeze: 10 code files + 0 regenerated baseline files = 10 files, 433 changed lines. The coordinator-authorized exception permits the reviewed final baseline set up to 19 files; replace this line with actual final counts after adoption.

LCD Power, SWR and ALC previously had text readings without persistent printed scales. Add one passive 20-segment LCD component across Peer, Dominant, Centerstage and Panadapter. Supported scales retain their DOM while RX shows empty IDLE, stale/missing observations remain empty with their cue, and current readings use canonical capability calibration and honest units, including zero and raw values. The full shared TX display facet remains authoritative; VD/ID/COMP output is preserved.

Keep labels and ordinary readouts at least 8 effective pixels, with a 7px minimum for long honest readouts such as 255 raw ?. Reserve the declared native stage floor and frame border in the LCD shell. Sidebars retain 228px preferred width, shrink to a usable 216px floor, then the entire constrained row scrolls horizontally. Native canvases and proportions are unchanged; 1280 primary geometry is exact, while 1100 gains the small uniform scale/position adjustment required to show the whole stage. Cockpit/scope keep their existing grid.

Validation: 316 focused tests (301 meter/display cases plus 15 existing LCD-layout controls), 22 fixture browser checks, Svelte/TypeScript checks and focused lint passed. Browser checks explicitly load the bundled font and measure actual text Range widths, effective text size, honest long values, clipping ancestors, native geometry, sidebar control/label containment, focus/hit testing and real horizontal wheel scrolling at 1000/760. Eight shell mutations and six earlier readability mutations were detected; equivalent controls passed. No full local suite or hardware validation.

Pending before ready: exact Linux artifact inspection and conditional baseline adoption, final counts above, exact-head CI and independent review. MOR-1413 operator acceptance remains open; the 7px long-readout edge is explicit.

Current Linux validation is FAILED (test_failure): regeneration run 33993832517 at 9eadd81 passed 51/53 tests but failed both Dominant long-readout cases. The logged loaded-font text Range for 10000W ? exceeds its available width (44.9583 vs 42.8704px at 1280; 36.0146 vs 34.3420px at 1100). Local results above are macOS-only and do not establish Linux fit. No generated PNG or manifest has been adopted. The bounded correction cycle is stopped; this PR stays Draft pending a revised plan and owner continuation.

@morozsm

morozsm commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this draft: the feature is still wanted, this head is not the way to it. The branch codex/mor2372-lcd-tx-scales is kept and the state is recorded on MOR-2372, which stays open.

Why closed rather than continued:

  • This PR's own body records that its Linux font-fit validation FAILED on both Dominant long-readout cases and that the correction cycle stopped pending a revised plan and owner continuation. It never reached its own acceptance.
  • It is 262 commits behind main with conflicts in lcd-display-helpers.ts, three test files and visual-baselines.spec.ts.
  • At 10 files and +406/−27 it is already at the file ceiling before the regenerated visual baselines it would need.

Nothing was superseded: no LcdTxMeterScales exists on main, and CenterstageDisplay.svelte, LcdTelemetryRail.svelte and PanadapterDisplay.svelte still render plain text labels. The work resumes from MOR-2372 with a revised plan on current main.

@morozsm morozsm closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant