Skip to content
This repository was archived by the owner on Jun 6, 2021. It is now read-only.

Feature/bulk sending#44

Open
rjmunro wants to merge 4 commits into
richsage:masterfrom
whiteoctober:feature/bulk-sending
Open

Feature/bulk sending#44
rjmunro wants to merge 4 commits into
richsage:masterfrom
whiteoctober:feature/bulk-sending

Conversation

@rjmunro

@rjmunro rjmunro commented Aug 14, 2013

Copy link
Copy Markdown
Contributor

Begin work on bulk sending of push messages. Not ready for merging yet, just posting for comment purposes.

Depends on: #36 being merged first.

Comment thread Service/Notifications.php Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't typehint for string

queue() queues messages without calling sendMessages(), so you can
then call sendMessages manually.

Refactored send to call queue() then sendMessages().

Tidied code a little to conform to PSR-2
@ghost

ghost commented Nov 18, 2013

Copy link
Copy Markdown

I think this is a quite important feature actually. How can we accelerate the work on this?

@richsage

Copy link
Copy Markdown
Owner

@rjmunro are you able to look at this again?

@abbood

abbood commented Jul 8, 2014

Copy link
Copy Markdown

can't this just be done by combining this library with a delayed job kinda library like BCCResqueBundle?

@rjmunro

rjmunro commented Jul 8, 2014

Copy link
Copy Markdown
Contributor Author

@abbood The push message providers offer nice bulk sending capabilities, but we are not using them. Adding a queue library would not help with this.

@guidolodetti

Copy link
Copy Markdown

Does this bundle work with multiple messages? I'm viewing the source code but really, I can't understand!

Comment thread Service/Notifications.php

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be nice to create a BulkNotificationInterface instead of doing this ?

@muffe

muffe commented Jan 23, 2015

Copy link
Copy Markdown

@rjmunro Whats the status of this?

@ruscon

ruscon commented May 14, 2015

Copy link
Copy Markdown

ping ?

@romeugodoi

Copy link
Copy Markdown

@rjmunro How is this issue? tks.

@rjmunro

rjmunro commented Nov 3, 2017

Copy link
Copy Markdown
Contributor Author

I'm not able to do any more work on this. If someone wants to take it over, please do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants