Repository navigation
[GPTEINFRA-18460] Retry HCO readiness through transient webhook outages - #200
Merged
Merged
Conversation
prakhar1985
requested review from
fridim,
rut31337,
stencell and
wkulhanek
as code owners
November 6, 2026 01:29
d-jana
approved these changes
Nov 6, 2026
andrew-jones
pushed a commit
that referenced
this pull request
Nov 11, 2026
The 'Create the HyperConverged instance' task applies the HyperConverged CR immediately after the kubevirt-hyperconverged CSV is subscribed. While the operator is still rolling out, the HCO conversion webhook (hco-webhook-service:4343) is not yet serving, so the apply fails with: conversion webhook for hco.kubevirt.io/v1, Kind=HyperConverged failed: Post "https://hco-webhook-service.openshift-cnv.svc:4343/convert": connect: connection refused (HTTP 500) #200 added retry/until to the subsequent read ('Wait until HyperConverged is installed') but left the apply itself unprotected, so a webhook outage during the apply still fails the deploy outright. Add the same retry/until to the apply, reusing the existing hco_wait_retries/hco_wait_delay vars. Observed intermittently on the RHACS CNV demo (rhacs-demo-cnv); the operator took ~11 min to reach CSV Succeeded, and the apply landed in that window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
During a MachineConfig rollout, a node reboot can temporarily remove the HCO conversion webhook. The module internal wait exits on the resulting HTTP 500 even though installation subsequently recovers. Retrying the API query handles this transient outage without suppressing persistent failures.
Validation
Scope
No changes to MachineConfigs, catalog versions, or the live cluster. This role does not manage MachineConfigs; callers remain responsible for sequencing external rollouts.
Jira: https://redhat.atlassian.net/browse/GPTEINFRA-18460