Repository navigation
Expose Argo CD command parameters in OpenShift GitOps workload - #198
Merged
Merged
Conversation
evanshortiss
requested review from
fridim,
rut31337,
stencell and
wkulhanek
as code owners
October 30, 2026 23:40
Contributor
|
@juliaaano Please do a quick review on this. Looks fine to me, especially since anyone who wants to use it has to opt-in. |
Contributor
|
It does looks fine. I've asked a question to @evanshortiss in Slack and I will post the summary of our conversation here once we're done. Meanwhile he mentioned he would also test this today (Monday), so I'll convert this to draft and wait for that before merging. |
juliaaano
marked this pull request as draft
November 2, 2026 10:22
juliaaano
marked this pull request as ready for review
November 2, 2026 19:15
juliaaano
approved these changes
Nov 2, 2026
juliaaano
left a comment
Contributor
There was a problem hiding this comment.
Great stuff. As discussed with Evan, this setting makes sense and it enables keeping compatibility with upstream argocd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenShift GitOps workload cannot currently configure
spec.cmdParamson its ArgoCD custom resource. This prevents callers from configuring settings such ascontroller.resource.health.persist: "false"to keep per-resource health in Redis instead of also persisting it in Application status.Add
ocp4_workload_openshift_gitops_cmd_params, documented with an example in the role defaults, and render it asspec.cmdParamswhen non-empty. The default is an empty mapping, preserving the existing rendered resource. Parameter values must be strings, and the installed OpenShift GitOps version must supportspec.cmdParams.Validation:
spec.cmdParamschanges, with"false"preserved as a string.git diff --checkpassed.resourceHealthSource: appTree, and resource health remained available through the Argo CD API. A fresh role installation has not been run.