Skip to content

Expose optional Dev Spaces workspace storage strategy - #197

Merged
wkulhanek merged 1 commit into
rhpds:mainfrom
l3acon:feat/devspaces-pvc-strategy
Nov 2, 2026
Merged

wkulhanek merged 1 commit into
rhpds:mainfrom
l3acon:feat/devspaces-pvc-strategy

Conversation

@l3acon

@l3acon l3acon commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Ansible Island Adventure instructors need to keep their instructor-toolkit and participant workspaces running together. Raising the running-workspace limit alone leaves them sharing a per-user ReadWriteOnce volume, which can cause Multi-Attach failures when the pods land on different nodes.

Expose ocp4_workload_devspaces_pvc_strategy and render spec.devEnvironments.storage.pvcStrategy when it is set. The default is an empty string, so the generated CheCluster is unchanged for existing consumers. Document the two-workspace configuration and the fact that changing storage defaults does not migrate existing workspace data.

The dependent Ansible Island Adventure leaderboard CI change, https://github.com/rhpds/agnosticv/pull/28869, opts into two running workspaces and per-workspace storage. It is a draft pending this workload feature. Other labs do not opt in automatically.

Validation:

  • Rendered the default configuration and confirmed it matches the previous CheCluster.
  • Rendered all three explicit strategies: per-user, per-workspace, and ephemeral.
  • Rendered the proposed leaderboard overrides and verified two saved/running workspaces, integer limits, and per-workspace storage.
  • Passed yamllint on the modified defaults and git diff --check.
  • Equivalent CheCluster settings were tested on an existing OpenShift deployment: two workspaces for one instructor reached Running with separate bound PVCs and editor HTTP 200. This does not replace validation of a fresh CI deployment after the dependent catalog change.

@stencell

stencell commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@treddy08 Can you have a quick look at this? It looks fine to me, especially since it is opt-in to use it.

@stencell
stencell requested a review from treddy08 November 2, 2026 08:34
@wkulhanek
wkulhanek merged commit 5c5fca0 into rhpds:main Nov 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants