Skip to content

[GPTEINFRA-18402] Check ArgoCD repo access in ocp4_workload_field_content - #196

Merged
wkulhanek merged 3 commits into
mainfrom
field-content-argo-repo-check
Nov 3, 2026
Merged

wkulhanek merged 3 commits into
mainfrom
field-content-argo-repo-check

Conversation

@stencell

Copy link
Copy Markdown
Contributor

Summary

Makes field content repo problems (typo in URL or revision, bad token, broken chart) visible in the order details instead of failing silently in ArgoCD. The provision never fails on this check.

Changes

  • Wait up to 5 minutes for the default AppProject before creating the Application. This removes a false "project default which does not exist" warning.
  • After the Application is created, poll it for up to 30 seconds. On ComparisonError or InvalidSpecError, add a warning with the ArgoCD message to user info. A sync status (Synced/OutOfSync) means OK. No sync or health wait.
  • Save field_content_gitops_repo_url, field_content_gitops_repo_revision and field_content_argocd_app_namespace to user data for catalog info messages.
  • Retries and delay in defaults; README updated.

Related: rhpds/agnosticv#28865.

🤖 Generated with Claude Code

stencell and others added 3 commits October 30, 2026 13:24
After the Application is accepted, poll it for up to 30 seconds until
ArgoCD either reports a sync status or a ComparisonError or
InvalidSpecError condition. On an error, add a warning with the ArgoCD
message to user info, so a typo in the repo URL or revision, a bad
token, or a broken chart is visible in the order details.

The provision never fails on this check, and the role still does not
wait for sync or health. Retries and delay are set in defaults. The
README and defaults comments describe the new step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Write field_content_gitops_repo_url, field_content_gitops_repo_revision
and field_content_argocd_app_namespace to user data, so catalog info
messages can show the repo and link to the ArgoCD application.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The GitOps operator creates the default AppProject some seconds after
the ArgoCD instance. An Application created before that gets an
InvalidSpecError, and the repository check then reports a false
"project default which does not exist" warning in user info, even
though ArgoCD syncs the Application once the project exists.

Wait up to five minutes for the default AppProject before creating the
Application.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wkulhanek
wkulhanek merged commit 20304f0 into main Nov 3, 2026
1 check passed
@wkulhanek
wkulhanek deleted the field-content-argo-repo-check branch November 3, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants