feat: add non-breaking virtual-hosted-style support#38
Open
rhnvrm wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetUsePathStyle(bool)for explicit path-style vs virtual-hosted-style controlCreateUploadPolicies()form fields and policy conditionsWhy
Issue #36 asks for real virtual-hosted-style support. PR #37 relaxed bucket validation, but it did not fully solve addressing resolution across runtime, presigned, and policy surfaces, and it risked breaking existing callers.
This PR keeps bucket-scoped APIs bucket-scoped, adds explicit client-level addressing control, and preserves existing behavior by default.
Compatibility
CreateUploadPolicies()defaults keep their legacy action URL behavior by defaultSetUsePathStyle(false)Tests
Ran focused regression/feature coverage for the changed addressing surfaces:
Closes #36.
Supersedes #37.