Skip to content

Make the Google Forms style reusable - #1490

Merged
JackWilb merged 2 commits into
devfrom
codex/google-form-style
Sep 25, 2026
Merged

JackWilb merged 2 commits into
devfrom
codex/google-form-style

Conversation

@JackWilb

@JackWilb JackWilb commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Why

The Google Forms style lived inside one demo and selected its title by response ID, so another study could not reuse it cleanly. Closes #859.

Architecture

The stylesheet and example header image now live in revisitAssets/. The styling demo references the shared stylesheet from two components: the existing image form and a new questionnaire with different response IDs and no header image. ResponseSwitcher adds a class based on each response type, allowing the stylesheet to render divider responses without a question card. Divider responses no longer advance question numbering.

User-facing impact

The Styling Demo has a second form page showing reusable cards and a section divider. Other studies can reference revisitAssets/googleForm.css through stylesheetPath.

Validation

  • Focused ResponseSwitcher and ResponseBlock unit suites: 57 tests passed.
  • yarn typecheck, yarn lint, and yarn build: passed.
  • Opened the new Styling Demo page locally in a browser and checked the cards and divider.
  • Remote checks: pending.

Risk and rollout

Existing configs that reference the old demo-specific CSS or image paths must use the new shared paths. The repository's references are updated. No special rollout is needed.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🪓 PR closed, deleted preview.

@JackWilb
JackWilb force-pushed the codex/google-form-style branch from 3f1012c to 0efbffc Compare September 25, 2026 21:19
@JackWilb
JackWilb changed the base branch from main to dev September 25, 2026 21:19
@JackWilb
JackWilb marked this pull request as ready for review September 25, 2026 21:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T21:24:51.325898Z 897ccd5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@JackWilb
JackWilb marked this pull request as draft September 25, 2026 21:20
@JackWilb
JackWilb force-pushed the codex/google-form-style branch from 0efbffc to 897ccd5 Compare September 25, 2026 21:21
@JackWilb
JackWilb marked this pull request as ready for review September 25, 2026 21:21
@JackWilb
JackWilb merged commit 5c5028d into dev Sep 25, 2026
16 of 17 checks passed
@JackWilb
JackWilb deleted the codex/google-form-style branch September 25, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create library of styles

1 participant