Show Help for component-level help text - #1489
Merged
Merged
Conversation
Contributor
|
🪓 PR closed, deleted preview. |
7 tasks
JackWilb
marked this pull request as ready for review
September 25, 2026 21:12
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A study with only component-level
helpTextPathcannot open its help text because the header hides the Help button. Closes #1438.Architecture
The header already resolves the current component the same way as
HelpModal. Its button condition now checks the resolved component path first, then the global path. The modal's existing path selection and button behavior are unchanged.User-facing impact
Participants see Help on components that define their own help text, even when the study has no global help path. Help remains hidden when neither path exists.
Validation
yarn unittest run src/components/interface/tests/AppHeader.spec.tsx src/components/interface/tests/HelpModal.spec.tsx— 28 passed.yarn lint— passed.yarn typecheck— passed.Risk and rollout
Low risk: the change affects only Help-button visibility. The tests cover component-only, global-only, both, and neither cases, plus component path precedence in the modal. No special rollout is needed.