types: use girgen instead of ts-for-gir#59
Draft
retrozinndev wants to merge 2 commits into
Draft
Conversation
also stopped using the now-deprecated `Gtk.Widget.get_allocation` method, replacing it with `Gtk.Widget.compute_bounds`
this is still being used in gtk4
retrozinndev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're now using
girgenwhich is a better option for type generation both in speed and completion for signals, properties and so much passion and i wish that i could ccccc...Warning
This is a WIP, we still have to wait for libraries like
gnimandagsto use this(mainlygnim)By the way, this also removes code that was making use of deprecated methods like
Gtk.Widget.get_allocation,Gtk.Widget.showandGtk.Widget.hide, using their respective modern replacements:Gtk.Widget.compute_bounds(with parent) andGtk.Widget.set_visible.