ci(sandbox): run real Docker containment tests - #328
Open
Jake Present (jakepresent) wants to merge 2 commits into
Open
ci(sandbox): run real Docker containment tests#328Jake Present (jakepresent) wants to merge 2 commits into
Jake Present (jakepresent) wants to merge 2 commits into
Conversation
Jake Present (jakepresent)
requested review from
Chang Liu (changliu2) and
tangym
as code owners
August 20, 2026 05:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ASSERT's real Docker sandbox tests are guarded by
ASSERT_RUN_DOCKER_TESTS=1, but no automated workflow sets that variable. The normal unit workflow collects the file and silently skips all four live containment tests.Fix
Add a path-scoped GitHub Actions workflow that:
tests/test_sandbox_runtime_docker.pyVerification
Follow-up
The current repository ruleset requires PR review but does not require status checks. Once this workflow has a stable check context, the repository ruleset can make
Sandbox: real Docker containmenta required check for matching changes.