Skip to content

ci(sandbox): run real Docker containment tests - #328

Open
Jake Present (jakepresent) wants to merge 2 commits into
mainfrom
jake/ci-sandbox-docker-tests
Open

ci(sandbox): run real Docker containment tests#328
Jake Present (jakepresent) wants to merge 2 commits into
mainfrom
jake/ci-sandbox-docker-tests

Conversation

@jakepresent

Copy link
Copy Markdown
Collaborator

Problem

ASSERT's real Docker sandbox tests are guarded by ASSERT_RUN_DOCKER_TESTS=1, but no automated workflow sets that variable. The normal unit workflow collects the file and silently skips all four live containment tests.

Fix

Add a path-scoped GitHub Actions workflow that:

  • installs ASSERT's test dependencies on Ubuntu/Python 3.11
  • enables and runs tests/test_sandbox_runtime_docker.py
  • triggers for sandbox runtime, inference integration, example, test, dependency, and workflow changes
  • always checks for leftover target/relay containers and networks, including after test failure

Verification

  • Workflow YAML parses successfully.
  • The repository's exact Docker suite command is encoded in the workflow.
  • Live execution will be verified from this PR's GitHub Actions run; local clean-image execution is currently blocked before product code by the local Docker builder's PyPI TLS handshake failure.

Follow-up

The current repository ruleset requires PR review but does not require status checks. Once this workflow has a stable check context, the repository ruleset can make Sandbox: real Docker containment a required check for matching changes.

Comment thread .github/workflows/sandbox-docker.yml Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants