Skip to content

Use update manifest for extension setup#1

Merged
Nek-12 merged 1 commit into
mainfrom
download-extension-from-update-manifest
Jun 2, 2026
Merged

Use update manifest for extension setup#1
Nek-12 merged 1 commit into
mainfrom
download-extension-from-update-manifest

Conversation

@Nek-12

@Nek-12 Nek-12 commented Jun 2, 2026

Copy link
Copy Markdown
Member

Summary

  • stop packaging extension artifacts inside the npm package
  • resolve setup extension install URLs from the remote Firefox update manifest with exact CLI-version matching
  • move release checks to validate update-manifest entries and signed XPI payloads against dist/extension

Verification

  • bun run typecheck
  • bun run lint:eslint
  • bun run test packages/cli/src/cli-setup-doctor.test.ts scripts/test/package-check.test.ts scripts/test/prepare-release-version.test.ts scripts/test/package-signed-extension.test.ts
  • bun run build:artifacts && bun run package:verify
  • node dist/package/bin/firefox-cli.js setup --json
  • bun run check: initial pass succeeded before review fixes; final rerun hit transient process-runner kill EPERM, and immediate rerun of scripts/test/process-runner.test.ts passed

Note: AMO_SOURCE_REVIEW.md was already deleted in the worktree before this branch and is intentionally not included.

@Nek-12

Nek-12 commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Nek-12 Nek-12 merged commit 7fbab0f into main Jun 2, 2026
10 checks passed
@Nek-12 Nek-12 deleted the download-extension-from-update-manifest branch June 2, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant