fix: get_terms() to handle missing local_terms gracefully

[vorasmit]

Summary

Fixed the get_terms() method in the SalesOrder controller to gracefully handle cases where local_terms is None or missing, preventing AttributeError exceptions when the AI response omits this field.

Key Changes

• Refactored get_terms() method: Replaced walrus operator with explicit null-coalescing logic to safely handle None values for local_terms
• Added defensive initialization: Initialize local_terms to an empty frappe._dict() when it's None, allowing safe attribute access
• Improved readability: Simplified the conditional logic for better maintainability

Implementation Details

The original implementation used a walrus operator that would fail with AttributeError if self.data.local_terms was None. The updated approach:

1. Safely checks if local_terms exists, defaulting to an empty dict if not
2. Extracts description and incoterms attributes with fallback to empty string
3. Maintains the same output format while being more robust

Testing

Added comprehensive test coverage:

• test_get_terms_with_local_terms: Validates normal operation with complete data
• test_get_terms_with_missing_local_terms: Ensures graceful handling when local_terms is None
• test_get_terms_with_partial_local_terms: Tests edge case with only description present

https://claude.ai/code/session_01B3hHouqds5m6xkcYetE8KY

[greptile-apps]

Confidence Score: 5/5

Safe to merge — the change is a narrow, well-tested guard around a single attribute access with no side effects.

The production change is a two-line fix that adds a null-safe fallback before attribute access. The existing test suite is extended with cases that exercise every realistic local_terms state, and all assertions match the expected output. No other code paths are touched.

No files require special attention.

Important Files Changed

Filename	Overview
transaction_parser/transaction_parser/controllers/transaction.py	Replaces walrus-operator attribute access on potentially-None local_terms with a safe or frappe._dict() fallback; fix is correct and minimal.
transaction_parser/tests/test_sales_order.py	Adds four new test cases covering normal, None, partial, and absent local_terms scenarios; all assertions are correct for the updated logic.

_{Reviews (2): Last reviewed commit: "test: add omitted local_terms key case f..." | Re-trigger Greptile}

[coderabbitai]

📝 Walkthrough

Walkthrough

SalesOrder.get_terms() now handles missing local_terms by using a fallback dictionary before reading description and incoterms. The sales order test suite adds coverage for complete local_terms, local_terms = None, and partial local_terms with only a description present.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is directly related to the code changes and test coverage in this pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly matches the main change: making get_terms() handle missing local_terms safely.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 34cd9197-7ee5-48b1-9d58-c9a1192e5e1b

📥 Commits

Reviewing files that changed from the base of the PR and between b255a55 and aba5b1e.

📒 Files selected for processing (2)

• transaction_parser/tests/test_sales_order.py
• transaction_parser/transaction_parser/controllers/transaction.py