Skip to content

fix: support single group lookup and allow partial updates in group tools - #19

Open
Tyagiquamar wants to merge 1 commit into
requestly:mainfrom
Tyagiquamar:fix/group-tools-lookup-and-partial-updates
Open

fix: support single group lookup and allow partial updates in group tools#19
Tyagiquamar wants to merge 1 commit into
requestly:mainfrom
Tyagiquamar:fix/group-tools-lookup-and-partial-updates

Conversation

@Tyagiquamar

Copy link
Copy Markdown

This PR improves group tool capabilities and input handling in the Requestly MCP server:

  1. Single Group Lookup in get_groups: Added groupId parameter to get_groups schema and routed it through buildResourceUrl('groups', groupId) with URL-encoding and path-traversal protection.
  2. Partial Updates in update_group: Made name optional and removed hardcoded default values (status: 'Active', isFavourite: false) from updateGroup schema so partial group updates don't overwrite existing status or favourite state.
  3. Clean Payload Framing in create_group: Explicitly constructed the payload object to prevent extra or internal arguments from leaking into the upstream API body.
  4. Schema Correction: Marked ruleId as required in updateRuleSchemas base fields.
  5. Unit Tests: Added test coverage for group tools (create_group, get_groups for all & single group lookup, update_group partial updates, and delete_group).

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0adc2520-4ffa-4a5f-a2b2-78c87d7db42e


Comment @coderabbitai help to get the list of available commands.

@CLAassistant

CLAassistant commented Sep 4, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Tyagiquamar

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants