Add commands export to index.ts#824
Open
kohlmannj-nyt wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 51f677c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Hi @kohlmannj-nyt, thanks for contributing. I'm ok to expose it but you may need to double check if that's the approach you want to do. There are some nuances in using that, as that code need to work in multiple environments. That's why you see the So your best bet is generally provide your util outside. btw, the CI failed due to formatting, can you adjust the code and try again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I'm attempting to use
storybook-addon-viswith a custom Playwright browser command:vitest.config.ts
storybook-addon-vis.setup.ts
Theoretically all I need for this to work is for
storybook-addon-visto re-export the Vitest Browser Modecommandsexport, hence this PR! Thanks for your consideration.Aside: There are a few ways we could do this, but we want the underlying mechanism for switching to Dark Mode to be based on Playwright's
page.emulateMedia(), as this is closely matches how a real user's system-wide Dark Mode setting would operate. Vitest Browser Mode'spageobject does not expose this method, hence the custom browser command.