Repository navigation
Ignore handshake validation failures after the server transport closes - #432
Merged
Merged
Conversation
Closing the server transport consumes sessions whose handshake validation is still pending. Ignore a later validation rejection before reading the session so shutdown cannot cause an unhandled rejection. Keep normal validation failures on the existing rejection path. Assisted-by: Replit
Armster15
marked this pull request as ready for review
October 21, 2026 22:59
Armster15
requested review from
daweifeng-replit and
rileyjones-dev
and removed request for
a team and
rileyjones-dev
October 21, 2026 22:59
Armster15
enabled auto-merge (squash)
October 21, 2026 22:59
daweifeng-replit
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fix a regression from #427: if custom handshake validation rejects after the server transport closes, handling that rejection reads a consumed session and causes an unhandled rejection.
What changed
Return early from the validation catch when the pending session has already been consumed. Normal validation failures still use the existing rejection path.
Add one public-boundary regression test that pauses validation, closes the server transport, and rejects validation. It checks that the server stays closed with no pending or connected sessions and never emits a connected transition. Vitest also fails the run on any unhandled rejection.
Validation:
Versioning
No protocol or API change.
~ written by ⠕ Replit