ci(walletkit-maestro): bump WalletConnect/actions pin to pick up timeout bumps#536
Merged
Merged
Conversation
Picks up the timeout bumps from WalletConnect/actions#98: - pay_confirm_and_verify: pay-result-success-icon 30s → 60s - pay_open_and_paste_url: button-scan 60s → 90s Driven by pay-core CD's Maestro pass rate landing at 41.67% (5/12) across the 2026-06-05 → 2026-06-12 KPI window. The previous pin (3a145ab) predates #98 by one commit, so every one of those 12 CD runs hit the old timeouts. Bumping here so pay-core's next CD revalidate-after-rn-wallet-bump actually exercises the new budget. No flow logic changes in #98; only the two extendedWaitUntil timeouts. Other repos sharing this composite action (Reown SDK Maestro suites) are unaffected — the bumps are upward only and end as no-ops on green runs (extendedWaitUntil returns as soon as the element renders).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @jakubuid's task in 49s —— View job Review
✅ No issues found Notes:
|
ganchoradkov
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the WalletConnect/actions SHA pin in
walletkit-build-and-maestro/action.yml:Picks up WalletConnect/actions#98:
pay_confirm_and_verify.yamlpay-result-success-iconpay_open_and_paste_url.yamlbutton-scanWhy now
Pay-core's
core (CD)KPI for window 2026-06-05 → 2026-06-12: pass rate 41.67% (5/12). Investigation showed 5 of 7 failures stuck onpay-result-success-icon is visible(wallet on "Processing your payment…" while staging gateway took 35–50s to flipstatus=succeeded), and 2 of 7 stuck onbutton-scancold-start.The pin here (
3a145ab) is one commit before #98, so none of those 12 CD runs exercised the new budget — we have zero post-bump evidence and the KPI is a pre-bump baseline.This PR is the missing link so pay-core's next pin-bump in
sub-validate-advisory.ymlactually picks up the new timeouts.Risk
Other Reown SDK Maestro suites that use this composite (the scheduled
ci_e2e_walletkit.yaml, anywhere else?) inherit the same higher budgets. Both changes are upward only andextendedWaitUntilexits as soon as the element appears — green runs see no change, only previously-timing-out runs gain headroom.Test plan
ci_e2e_walletkit.yamlMaestro pay-tests run (every 6h per ci(walletkit): run scheduled Maestro pay tests every 6 hours #532) and confirm it stays green at the new timeouts.sub-validate-advisory.ymlfrom4e6dcea0→ tip ofmainhere, and the next 10 CD runs are observed.🤖 Generated with Claude Code