feat(controllers): add includePayOnly and sort options to fetchWallets#5685
Merged
Conversation
🦋 Changeset detectedLatest commit: 15d14e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
Contributor
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=930 👉 Please review the visual changes in Chromatic and accept or reject them. |
Contributor
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit > size-limit |
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
0xmkh
approved these changes
Jun 5, 2026
Surface wallets that support WalletConnect Pay but are not v2-compatible (filtered out by default) and allow sorting WCP-supporting wallets to the top, via two new useAppKitWallets().fetchWallets() options: - includePayOnly -> include_pay_only=true query param - sort: 'wcpay' -> sort=wcpay query param Both flow through fetchWalletsByPage and searchWallet into the /getWallets request. Default behavior is unchanged when the options are omitted, so general AppKit consumers keep hiding WCP-only wallets. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
enesozturk
force-pushed
the
feat/fetch-wallets-include-pay-only
branch
from
e66e0d6 to
15d14e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new options to
useAppKitWallets().fetchWallets()so headless consumers can surface WalletConnect Pay-capable wallets that the WalletGuide API hides by default:includePayOnly?: boolean→ sendsinclude_pay_only=true. By default/getWalletsreturns onlyis_v2_compatiblewallets, which filters out wallets that support WalletConnect Pay but aren't v2-compatible. This relaxes that tois_v2_compatible OR supports_wcpay.sort?: 'default' | 'wcpay'→ sendssort=wcpay, bubbling WCP-supporting wallets to the top.Both flow through
fetchWalletsByPageandsearchWalletinto the/getWalletsrequest (same pattern as the existingbadge → badge_typemapping). Default behavior is unchanged when the options are omitted — general AppKit consumers keep hiding WCP-only wallets.The backend (
web3modal-api) already supports both query params;WcWalletalready exposessupports_wcpay. This PR is purely the client plumbing to opt in.Motivation
WalletConnect Pay's Buyer Experience needs to list WCP-supporting wallets (including WCP-only ones) that wouldn't otherwise appear via the AppKit hooks, without changing behavior for other AppKit integrations.
Changes
packages/controllers/src/utils/TypeUtil.ts— addinclude_pay_onlyandsorttoApiGetWalletsRequest.packages/controllers/src/controllers/ApiController.ts— accept/forward the options infetchWalletsByPage,searchWallet, and stringify the boolean infetchWallets.packages/controllers/exports/react.ts— add the options to the publicFetchWalletsOptions.@reown/appkit-controllers).Testing
pnpm --filter @reown/appkit-controllers typecheck✅pnpm --filter @reown/appkit-controllers vitest run tests/controllers/ApiController.test.ts→ 52 passed, 1 skipped ✅🤖 Generated with Claude Code