Meetups: one search for where, a place or a street address - #286
Merged
Merged
Conversation
Creating or editing a meetup asked first whether it was at a place or at an address, and the search behind "a place" only knew named spots, so a home address found nothing and nothing said why. Where is now one search, as event apps have it: what Apple Maps finds comes as places and addresses (MKLocalSearch with .address, beside the .pointOfInterest search), and the words searched for can always be used as they are. An address chosen fills a field that can still be changed, a flat number say, with Apple's map under it while the words are Apple's. Only the words go to the server, as a typed address always has; nothing else Apple said is sent. A meetup made on the web shows where it was, and can go back there after a search. Adding a place still takes only spots on Apple Maps, and now says so under its search, and why when nothing is found. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating or editing a meetup used to start with a choice between "A place" and "An address". The search behind "A place" only finds named spots, so a home address found nothing, and nothing said why. Event apps have one location field instead, and this does the same.
Where is now one search (
ApplePlacePicker,ApplePlaceFinder(findsAddresses: true))PlaceDirectory.searchAddressesusesMKLocalSearchwith.address.Choosing an address
MapKitPlaceDirectorykeeps each address found as the answer for its own words, so the meetup's page needs no second lookup.Add a Place
Tests
testCreatingAMeetupAtAnAddressAppleMapsFound, which checks the map shows, the map goes once the words are changed, and the stored private address;Screenshots:
ios-native/docs/visual-parity/meetup-where-search.jpg. The new section is invisual-parity.md, andapple-maps-places-plan.mdnotes what is stored for an address.Suggestions while typing, before Return, are the next PR.
🤖 Generated with Claude Code