Skip to content

Meetups: one search for where, a place or a street address - #286

Merged
renrenmimi merged 1 commit into
mainfrom
ios-native/meetup-where-one-search
Oct 2, 2026
Merged

renrenmimi merged 1 commit into
mainfrom
ios-native/meetup-where-one-search

Conversation

@renrenmimi

Copy link
Copy Markdown
Owner

Creating or editing a meetup used to start with a choice between "A place" and "An address". The search behind "A place" only finds named spots, so a home address found nothing, and nothing said why. Event apps have one location field instead, and this does the same.

Where is now one search (ApplePlacePicker, ApplePlaceFinder(findsAddresses: true))

  • On Return, Apple Maps is searched for places and for street addresses at the same time. The new PlaceDirectory.searchAddresses uses MKLocalSearch with .address.
  • Results come in two groups, Places and Addresses. A last row, Use "…" as the address, takes the words as typed.
  • An address search that fails still leaves the places, and the typed-words row, on screen.

Choosing an address

  • It fills an Address field that can still be edited, for a flat number say.
  • Apple's map shows under it while the words are still Apple's (terms 2.4), and goes once they are edited.
  • Only the words are sent, exactly as for a typed address; nothing else Apple said goes with them. MapKitPlaceDirectory keeps each address found as the answer for its own words, so the meetup's page needs no second lookup.
  • Choose somewhere else goes back to the search. A meetup made on the web shows where it was and offers Keep where it was during a search.

Add a Place

  • Still takes only spots on Apple Maps, and never searches for addresses.
  • A footer under its search says so.
  • When nothing is found, it says that a home or street address can't be a place but a meetup can be at one.

Tests

  • Unit:
    • the address search runs only when asked, keeps the places when it fails, and remembers what was searched for;
    • an address Apple found is sent as words only;
    • the typed words can be the address;
    • starting again clears the address and label;
    • "keep where it was" works for web meetups only;
    • the directory caches addresses by their words;
    • the stand-in finds street addresses.
    • Full unit suite: 1061 passed, 0 failed.
  • UI:
    • updated the typed-address create test and the edit test;
    • added testCreatingAMeetupAtAnAddressAppleMapsFound, which checks the map shows, the map goes once the words are changed, and the stored private address;
    • re-ran create at an Apple place, add a place, and place search. All 6 pass.
  • The catalog has Chinese for the 9 new strings. The 4 that are no longer used are removed, and the harvested keys match the catalog (975 keys).

Screenshots: ios-native/docs/visual-parity/meetup-where-search.jpg. The new section is in visual-parity.md, and apple-maps-places-plan.md notes what is stored for an address.

Suggestions while typing, before Return, are the next PR.

🤖 Generated with Claude Code

Creating or editing a meetup asked first whether it was at a place or at
an address, and the search behind "a place" only knew named spots, so a
home address found nothing and nothing said why. Where is now one
search, as event apps have it: what Apple Maps finds comes as places and
addresses (MKLocalSearch with .address, beside the .pointOfInterest
search), and the words searched for can always be used as they are.

An address chosen fills a field that can still be changed, a flat number
say, with Apple's map under it while the words are Apple's. Only the
words go to the server, as a typed address always has; nothing else Apple
said is sent. A meetup made on the web shows where it was, and can go
back there after a search.

Adding a place still takes only spots on Apple Maps, and now says so
under its search, and why when nothing is found.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 2, 2026 07:23
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pet-note Ready Ready Preview Oct 2, 2026 7:23am UTC

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@renrenmimi
renrenmimi merged commit 6a41522 into main Oct 2, 2026
7 checks passed
renrenmimi added a commit that referenced this pull request Oct 2, 2026
STATUS: where a meetup is, one search and suggestions (#286, #287)

This branch was successfully deployed

1 active deployment
Preview — edc3b181 Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants