Repository navigation
fix: [RN-32757] upgrade action runtime to Node 24 (rh-changes) - #3
Merged
Merged
Conversation
fixes corymhall#74 Co-authored-by: Juho Majasaari <juho.majasaari@iki.fi> Co-authored-by: Roman <4456572+sturman@users.noreply.github.com>
rh-gglissmann
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks upstream
corymhall/cdk-diff-actioncommit corymhall#160 (chore: update dependencies) ontorh-changesto move the GitHub Action runtime from node20 → node24, while preserving this fork's multi-directory /ResourceImpactcustomizations that therenewhome/rhconsumer depends on.action.yml,.projenrc.ts: runtimenode20→node24;minNodeVersion/workflowNodeVersion→ 24@aws-cdk/cx-api→@aws-cdk/cloud-assembly-api(package rename)@aws-sdk/client-cloudformation;@types/node^20→^24dist/rebuilt from this branch's source on Node 24Why
Pick up the node24 runtime ahead of node20 deprecation for GitHub Actions, on the branch (
rh-changes) thatrenewhome/rhactually consumes.Conflict resolution
Only one source conflict —
src/stage-processor.tsimports — resolved to keep the fork'sResourceDifference, ResourceImpactimports and adopt thecloud-assembly-apipackage rename. Generated files (dist/,db.json.gz, lockfile) were regenerated by building on Node 24.Testing
renewhome/rhsynth_previewto this branch's SHA on a test PR.Note
The failing CodeQL check (
js/incomplete-sanitization) is a pre-existing finding in bundledfast-xml-parserdependency code, not introduced by this change and present in all current versions of that library.🤖 Generated with Claude Code