Skip to content

fix: [RN-32757] upgrade action runtime to Node 24 (rh-changes) - #3

Merged
rh-tanho merged 1 commit into
rh-changesfrom
node24-rh-changes
Sep 22, 2026
Merged

rh-tanho merged 1 commit into
rh-changesfrom
node24-rh-changes

Conversation

@rh-tanho

@rh-tanho rh-tanho commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Cherry-picks upstream corymhall/cdk-diff-action commit corymhall#160 (chore: update dependencies) onto rh-changes to move the GitHub Action runtime from node20 → node24, while preserving this fork's multi-directory / ResourceImpact customizations that the renewhome/rh consumer depends on.

  • action.yml, .projenrc.ts: runtime node20 → node24; minNodeVersion/workflowNodeVersion → 24
  • @aws-cdk/cx-api → @aws-cdk/cloud-assembly-api (package rename)
  • added @aws-sdk/client-cloudformation; @types/node ^20 → ^24
  • dist/ rebuilt from this branch's source on Node 24

Why

Pick up the node24 runtime ahead of node20 deprecation for GitHub Actions, on the branch (rh-changes) that renewhome/rh actually consumes.

Conflict resolution

Only one source conflict — src/stage-processor.ts imports — resolved to keep the fork's ResourceDifference, ResourceImpact imports and adopt the cloud-assembly-api package rename. Generated files (dist/, db.json.gz, lockfile) were regenerated by building on Node 24.

Testing

  • 30/30 tests pass; eslint clean on Node 24.
  • Built action loads and runs under Node 24 (reaches input validation).
  • End-to-end validation happens by pinning renewhome/rh synth_preview to this branch's SHA on a test PR.

Note

The failing CodeQL check (js/incomplete-sanitization) is a pre-existing finding in bundled fast-xml-parser dependency code, not introduced by this change and present in all current versions of that library.

🤖 Generated with Claude Code

fixes corymhall#74

Co-authored-by: Juho Majasaari <juho.majasaari@iki.fi>
Co-authored-by: Roman <4456572+sturman@users.noreply.github.com>
@rh-tanho rh-tanho changed the title Upgrade action runtime to Node 24 (rh-changes) fix: [RN-32757] upgrade action runtime to Node 24 (rh-changes) Sep 21, 2026
@rh-tanho
rh-tanho merged commit 3aec4cc into rh-changes Sep 22, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants