Repository navigation
RenewHome changes - #1
Open
rh-gglissmann wants to merge 4 commits into
Open
rh-gglissmann wants to merge 4 commits into
rh-gglissmann wants to merge 4 commits into
Conversation
This reverts commit ffb1df8.
rh-gglissmann
commented
Nov 6, 2025
Comment on lines
+197
to
+209
| // Ignore differences in Tags | ||
| for (const [_, stackDiff] of Object.entries(diffResult)) { | ||
| if (!stackDiff['resources'] || !stackDiff['resources']['diffs']) { | ||
| continue; | ||
| } | ||
| for (const [_, resourceDiff] of Object.entries(stackDiff['resources']['diffs'])) { | ||
| const typedResourceDiff = resourceDiff as ResourceDifference; | ||
| if (typedResourceDiff['propertyDiffs']['Tags']) { | ||
| typedResourceDiff['propertyDiffs']['Tags']['isDifferent'] = false; | ||
| typedResourceDiff['propertyDiffs']['Tags']['changeImpact'] = ResourceImpact.NO_CHANGE; | ||
| } | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This will be refactored and I will build an option around this.
Cherry-picks upstream corymhall/cdk-diff-action commit corymhall#160 (chore: update dependencies) onto rh-changes to move the GitHub Action runtime from node20 → node24, while preserving this fork's multi-directory / ResourceImpact customizations that the renewhome/rh consumer depends on. Pick up the node24 runtime ahead of node20 deprecation for GitHub Actions, on the branch (rh-changes) that renewhome/rh actually consumes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes RenewHome's forked changes to
cdk-diff-action, including: