Skip to content

RenewHome changes - #1

Open
rh-gglissmann wants to merge 4 commits into
mainfrom
rh-changes
Open

rh-gglissmann wants to merge 4 commits into
mainfrom
rh-changes

Conversation

@rh-gglissmann

@rh-gglissmann rh-gglissmann commented Nov 6, 2025 •

Copy link
Copy Markdown
Collaborator

This PR includes RenewHome's forked changes to cdk-diff-action, including:

  • Running CDK diff on many applications and merging the result together
  • Additional messaging on comments if an app has no stacks, etc.

This reverts commit ffb1df8.
@rh-gglissmann rh-gglissmann changed the title Revert "Revert main to fork" RenewHome changes Nov 6, 2025
Comment thread src/stage-processor.ts
Comment on lines +197 to +209
// Ignore differences in Tags
for (const [_, stackDiff] of Object.entries(diffResult)) {
if (!stackDiff['resources'] || !stackDiff['resources']['diffs']) {
continue;
}
for (const [_, resourceDiff] of Object.entries(stackDiff['resources']['diffs'])) {
const typedResourceDiff = resourceDiff as ResourceDifference;
if (typedResourceDiff['propertyDiffs']['Tags']) {
typedResourceDiff['propertyDiffs']['Tags']['isDifferent'] = false;
typedResourceDiff['propertyDiffs']['Tags']['changeImpact'] = ResourceImpact.NO_CHANGE;
}
}
}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be refactored and I will build an option around this.

Garrett Glissmann and others added 3 commits November 6, 2025 09:01
Cherry-picks upstream corymhall/cdk-diff-action commit corymhall#160 (chore: update dependencies) onto rh-changes to move the GitHub Action runtime from node20 → node24, while preserving this fork's multi-directory / ResourceImpact customizations that the renewhome/rh consumer depends on.

Pick up the node24 runtime ahead of node20 deprecation for GitHub Actions, on the branch (rh-changes) that renewhome/rh actually consumes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants