fix(logs): enforce documented limit and direction bounds server-side - #35
Open
aniruddhaadak80 wants to merge 1 commit into
Open
aniruddhaadak80 wants to merge 1 commit into
aniruddhaadak80 wants to merge 1 commit into
Conversation
list_logs documents limit 1-100 and direction backward/forward, but the handlers forwarded any values to the Render API, surfacing opaque downstream errors. Validate both locally (limit must be a whole number in 1-100, direction must be backward/forward) in list_logs and list_log_label_values and return clear tool errors. Fixes render-oss#32
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The tool schemas advertise limit Min 1 Max 100 and direction backward/forward, but the handlers forwarded any numeric limit (truncating fractions via int()) and any direction string to the Render API. Invalid values only failed downstream as opaque API errors.
Repro (before fix): list_logs with limit 1000 forwarded limit=1000; with direction sideways forwarded direction=sideways. After fix both return clear tool errors naming the valid values.
How tested
Fixes #32